* [PATCH] org.el: Make sure (org-agenda-files) search relative file paths in org-directory
[not found] <1282662860.5259786.1619091670864.ref@mail.yahoo.com>
@ 2021-04-22 11:41 ` Sun Lin
2021-04-28 21:19 ` Fw:[PATCH] " sunlin7@yahoo.com
2021-05-13 9:57 ` [PATCH] " Sun Lin
0 siblings, 2 replies; 6+ messages in thread
From: Sun Lin @ 2021-04-22 11:41 UTC (permalink / raw)
To: emacs-orgmode@gnu.org
[-- Attachment #1: Type: text/plain, Size: 370 bytes --]
Hi,
According the document of variable `org-agenda-files`, "In this file paths can be given relative to
‘org-directory’. ".
While it's failed to search the files for relative file paths in `org-agenda-files`.
The attachment is the patch try to search relative file paths in ‘org-directory’.
Please help to review and apply the patch.
Thanks
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org.el-Fix-org-agenda-files-search-files-in-org-dire.patch --]
[-- Type: text/x-patch, Size: 779 bytes --]
From: Lin Sun <lin.sun@zoom.us>
Date: Thu, 22 Apr 2021 04:26:47 +0000
Subject: [PATCH] org.el: Make sure (org-agenda-files) search relative file paths in org-directory
* lisp/org.el (org-agenda-files): Make sure org-agenda-files work with relative
file paths.
TINYCHANGE
---
lisp/org.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org.el b/org.el
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -15322,7 +15322,7 @@ used by the agenda files. If ARCHIVE is `ifmode', do this only if
(if (file-directory-p f)
(directory-files
f t org-agenda-file-regexp)
- (list f)))
+ (list (expand-file-name f org-directory))))
files)))
(when org-agenda-skip-unavailable-files
(setq files (delq nil
--
2.7.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Fw:[PATCH] org.el: Make sure (org-agenda-files) search relative file paths in org-directory
2021-04-22 11:41 ` [PATCH] org.el: Make sure (org-agenda-files) search relative file paths in org-directory Sun Lin
@ 2021-04-28 21:19 ` sunlin7@yahoo.com
2021-05-13 9:57 ` [PATCH] " Sun Lin
1 sibling, 0 replies; 6+ messages in thread
From: sunlin7@yahoo.com @ 2021-04-28 21:19 UTC (permalink / raw)
To: emacs-orgmode@gnu.org
[-- Attachment #1: Type: text/html, Size: 796 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org.el-Fix-org-agenda-files-search-files-in-org-dire.patch --]
[-- Type: text/x-patch; name="0001-org.el-Fix-org-agenda-files-search-files-in-org-dire.patch", Size: 779 bytes --]
From: Lin Sun <lin.sun@zoom.us>
Date: Thu, 22 Apr 2021 04:26:47 +0000
Subject: [PATCH] org.el: Make sure (org-agenda-files) search relative file paths in org-directory
* lisp/org.el (org-agenda-files): Make sure org-agenda-files work with relative
file paths.
TINYCHANGE
---
lisp/org.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org.el b/org.el
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -15322,7 +15322,7 @@ used by the agenda files. If ARCHIVE is `ifmode', do this only if
(if (file-directory-p f)
(directory-files
f t org-agenda-file-regexp)
- (list f)))
+ (list (expand-file-name f org-directory))))
files)))
(when org-agenda-skip-unavailable-files
(setq files (delq nil
--
2.7.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] org.el: Make sure (org-agenda-files) search relative file paths in org-directory
2021-04-22 11:41 ` [PATCH] org.el: Make sure (org-agenda-files) search relative file paths in org-directory Sun Lin
2021-04-28 21:19 ` Fw:[PATCH] " sunlin7@yahoo.com
@ 2021-05-13 9:57 ` Sun Lin
2021-05-21 2:30 ` Sun Lin
1 sibling, 1 reply; 6+ messages in thread
From: Sun Lin @ 2021-05-13 9:57 UTC (permalink / raw)
To: emacs-orgmode@gnu.org
[-- Attachment #1: Type: text/plain, Size: 423 bytes --]
(Resend with correct contributor email address)
Hi,
According the document of variable `org-agenda-files`, "In this file paths can be given relative to
‘org-directory’. ".
While it's failed to search the files for relative file paths in `org-agenda-files`.
The attachment is the patch try to search relative file paths in ‘org-directory’.
Please help to review and apply the patch.
Thanks
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-agenda-files-work-with-relateive-file-paths.patch --]
[-- Type: text/x-patch, Size: 844 bytes --]
From e963bd5554b076c813cde1f59d75f0686fec8a14 Mon Sep 17 00:00:00 2001
From: Sun Lin <sunlin7@yahoo.com>
Date: Thu, 13 May 2021 09:52:33 +0000
Subject: [PATCH] org-agenda-files: work with relateive file paths.
* lisp/org.el (org-agenda-files): Make sure org-agenda-files work with relative
file paths.
---
lisp/org.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org.el b/lisp/org.el
index b388bca..04e1f80 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -15395,7 +15395,7 @@ used by the agenda files. If ARCHIVE is `ifmode', do this only if
(if (file-directory-p f)
(directory-files
f t org-agenda-file-regexp)
- (list f)))
+ (list (expand-file-name f org-directory))))
files)))
(when org-agenda-skip-unavailable-files
(setq files (delq nil
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] org.el: Make sure (org-agenda-files) search relative file paths in org-directory
2021-05-13 9:57 ` [PATCH] " Sun Lin
@ 2021-05-21 2:30 ` Sun Lin
2021-05-21 16:31 ` Nicolas Goaziou
0 siblings, 1 reply; 6+ messages in thread
From: Sun Lin @ 2021-05-21 2:30 UTC (permalink / raw)
To: emacs-orgmode@gnu.org, mail@nicolasgoaziou.fr
[-- Attachment #1: Type: text/plain, Size: 92 bytes --]
Hi Nicolas,
Please help review and merge this patch. Thanks
Best Regards
Sun.Lin
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-agenda-files-work-with-relateive-file-paths.patch --]
[-- Type: text/x-patch, Size: 844 bytes --]
From e963bd5554b076c813cde1f59d75f0686fec8a14 Mon Sep 17 00:00:00 2001
From: Sun Lin <sunlin7@yahoo.com>
Date: Thu, 13 May 2021 09:52:33 +0000
Subject: [PATCH] org-agenda-files: work with relateive file paths.
* lisp/org.el (org-agenda-files): Make sure org-agenda-files work with relative
file paths.
---
lisp/org.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org.el b/lisp/org.el
index b388bca..04e1f80 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -15395,7 +15395,7 @@ used by the agenda files. If ARCHIVE is `ifmode', do this only if
(if (file-directory-p f)
(directory-files
f t org-agenda-file-regexp)
- (list f)))
+ (list (expand-file-name f org-directory))))
files)))
(when org-agenda-skip-unavailable-files
(setq files (delq nil
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] org.el: Make sure (org-agenda-files) search relative file paths in org-directory
2021-05-21 2:30 ` Sun Lin
@ 2021-05-21 16:31 ` Nicolas Goaziou
2021-05-22 1:18 ` sunlin7@yahoo.com
0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Goaziou @ 2021-05-21 16:31 UTC (permalink / raw)
To: Sun Lin; +Cc: emacs-orgmode@gnu.org
Hello,
Sun Lin <sunlin7@yahoo.com> writes:
> Subject: [PATCH] org-agenda-files: work with relateive file paths.
Applied. Thank you.
I added TINYCHANGE cookie at the end of the commit message as I wasn't
sure you had signed the FSF papers already.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re:[PATCH] org.el: Make sure (org-agenda-files) search relative file paths in org-directory
2021-05-21 16:31 ` Nicolas Goaziou
@ 2021-05-22 1:18 ` sunlin7@yahoo.com
0 siblings, 0 replies; 6+ messages in thread
From: sunlin7@yahoo.com @ 2021-05-22 1:18 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: emacs-orgmode@gnu.org
[-- Attachment #1: Type: text/html, Size: 829 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-22 1:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1282662860.5259786.1619091670864.ref@mail.yahoo.com>
2021-04-22 11:41 ` [PATCH] org.el: Make sure (org-agenda-files) search relative file paths in org-directory Sun Lin
2021-04-28 21:19 ` Fw:[PATCH] " sunlin7@yahoo.com
2021-05-13 9:57 ` [PATCH] " Sun Lin
2021-05-21 2:30 ` Sun Lin
2021-05-21 16:31 ` Nicolas Goaziou
2021-05-22 1:18 ` sunlin7@yahoo.com
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).