From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: ... Date: Thu, 31 Jan 2013 15:32:29 +0100 Message-ID: <16F8E2C8-5CAD-42F2-8146-42AEEF49D73A@gmail.com> References: <877gmt3dzq@ch.ristopher.com> <871ud13dkp@ch.ristopher.com> <6C559BF7-BACF-48AF-AB06-383D6AC14BDE@gmail.com> <87622dlhqm.fsf@bzg.ath.cx> <874nhxjx66.fsf@bzg.ath.cx> Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([208.118.235.92]:39692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0vBq-0005NM-3x for emacs-orgmode@gnu.org; Thu, 31 Jan 2013 09:32:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U0vBo-0007XT-QA for emacs-orgmode@gnu.org; Thu, 31 Jan 2013 09:32:33 -0500 Received: from mail-ea0-f169.google.com ([209.85.215.169]:44621) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0vBo-0007XB-Ky for emacs-orgmode@gnu.org; Thu, 31 Jan 2013 09:32:32 -0500 Received: by mail-ea0-f169.google.com with SMTP id d13so1231501eaa.14 for ; Thu, 31 Jan 2013 06:32:30 -0800 (PST) In-Reply-To: <874nhxjx66.fsf@bzg.ath.cx> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: Christopher Schmidt , "emacs-orgmode@gnu.org Mailing List" On 31 jan. 2013, at 14:32, Bastien wrote: > Hi Carsten, >=20 > thanks a lot for the very clear explanations. >=20 > Carsten Dominik writes: >=20 >> The difference is only the repeated concatenation operation, and not = the >> recompilation. I always thought that this would work differently, = and that >> is why a lot of regexps get constructed and then stored in variables = or >> constants. Of course this is also a good practice for readable and >> maintainable code, but the impact on efficiency is not as big as I = used to >> think. So when I saw Christoher's initial patch, I thought a = function to >> create >> org-ooutline-regexp-bol would be a large burden in speed - but it now = seems that it would only be a minor impact. >=20 > That was my assumption too... hence my reaction to Christopher's > patch. >=20 > It now makes sense -- I'll ask for confirmation on the emacs-devel as > suggested by Christopher. >=20 >> Still, I think making a local variable in buffers with >> org-struct-mode is also a good way to get the functionality >> Christopher wants. >=20 > Mh... here I'm not sure to understand what you suggest.=20 > Isn't the whole point of Christopher's patch to rely on > a buffer local value of org-outline-regexp? I surely miss > something. Not really, I am not particulrly clear here. Christopher proposes to do this: ;; Local Variables: ;; eval: (orgstruct-mode 1) ;; org-outline-regexp: ";;; \\*+" ;; org-heading-regexp: "^;;; \\(\\*+\\)\\(.+\\)$" ;; End: I was just thinking, if you are setting up two local variables, you = could set up three and include org-outline-regexp-bol as well. Or, you = could just set up `org-outline-regexp', and make the function = org-struct-mode set up the other two as additional local variables. = This would simplify things. In fact, I think this would make for a more = compact and better patch, Christopher, what do you think? - Carsten