From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dokos Subject: Re: Re: Bug fix: org-mhe links don't work with mairix Date: Sat, 17 May 2008 16:23:22 -0400 Message-ID: <17623.1211055802@gamaville.dokosmarshall.org> References: <21579.1210822289@gamaville.dokosmarshall.org> Reply-To: nicholas.dokos@hp.com Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JxSzA-000850-GP for emacs-orgmode@gnu.org; Sat, 17 May 2008 16:26:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JxSz8-00083Q-VM for emacs-orgmode@gnu.org; Sat, 17 May 2008 16:26:32 -0400 Received: from [199.232.76.173] (port=47021 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JxSz8-00083J-R0 for emacs-orgmode@gnu.org; Sat, 17 May 2008 16:26:30 -0400 Received: from qmta02.emeryville.ca.mail.comcast.net ([76.96.30.24]:38223) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JxSz8-0000QZ-GP for emacs-orgmode@gnu.org; Sat, 17 May 2008 16:26:30 -0400 In-Reply-To: Message from Thomas Baumann of "Sat, 17 May 2008 17:15:41 +0200." List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Thomas Baumann Cc: mh-e-users@lists.sourceforge.net, emacs-orgmode@gnu.org Thomas Baumann wrote: > Hi Nick, > > your patch actually breaks namazu, swish and grep searches. > > A look at mh-search-choices (mh-search.el) reveals that for namazu, > swish and grep mh-search-regexp-builder is nil and therefore > > (funcall mh-search-regexp-builder ... > > raises an error. One might be tempted to solve this on the mh-e side but > there's no reason to add a mh-search-regexp-builder for those search > engines. There's a patch against todays git below. > > BTW. Namazu and pick searches work fine without angular brackets, however, it > doesn't harm to have them. > > > Greetings > Thomas > Thomas, Yes indeed: sorry for the breakage and thanks for coming up with a fix. I agree that it's preferable to change the call site rather than asking for changes to mh-e. Thanks very much, Nick PS. For the record, the patch against mh-e that I sent earlier to both the mh-e and org lists has also been submitted on the mh-e sourceforge patches list at http://sourceforge.net/tracker/?group_id=13357&atid=313357 It's number 1965704. > > --- /data/cvs/org-mode/lisp/org-mhe.el 2008-05-17 12:54:07.000000000 +0200 > +++ org-mhe.el 2008-05-17 16:55:22.000000000 +0200 > @@ -204,8 +204,10 @@ > (not (org-mhe-get-message-real-folder))) > (kill-this-buffer) > (mh-search "+" (list "--message-id" article)))) > - (mh-search "+" (funcall mh-search-regexp-builder > - (list (cons 'message-id article))))) > + (if mh-search-regexp-builder > + (mh-search "+" (funcall mh-search-regexp-builder > + (list (cons 'message-id article)))) > + (mh-search "+" article))) > (if (org-mhe-get-message-real-folder) > (mh-show-msg 1) > (kill-this-buffer) > --45B245DFCA.1211054880/gamaville.dokosmarshall.org--