From mboxrd@z Thu Jan  1 00:00:00 1970
From: "George Kettleborough (EI)" <george.kettleborough@earlham.ac.uk>
Subject: ob-shell: using a table variable with bash
Date: Fri, 3 Mar 2017 12:40:54 +0000
Message-ID: <1811afdb-ffe4-37e7-9858-19b22d7ff2ed@earlham.ac.uk>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="------------A43AA0E6EF2FB462E0963951"
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46676)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <George.Kettleborough@earlham.ac.uk>)
	id 1cjwQi-00080n-9p
	for emacs-orgmode@gnu.org; Fri, 03 Mar 2017 18:16:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <George.Kettleborough@earlham.ac.uk>)
	id 1cjwQe-00055o-6S
	for emacs-orgmode@gnu.org; Fri, 03 Mar 2017 18:16:08 -0500
Received: from mail-db5eur01on0133.outbound.protection.outlook.com
	([104.47.2.133]:28770
	helo=EUR01-DB5-obe.outbound.protection.outlook.com)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <George.Kettleborough@earlham.ac.uk>)
	id 1cjwQd-00054o-KY
	for emacs-orgmode@gnu.org; Fri, 03 Mar 2017 18:16:04 -0500
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: emacs-orgmode@gnu.org

--------------A43AA0E6EF2FB462E0963951
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit

Hello,

I recently updated my org-mode from version 7 (I think) to the latest. 
The behaviour of using a table as a variable in a shell code source 
block has changed. I use to use it like this:

#+BEGIN_SRC sh :results output :var table=synteny-names :separator ,
   IFS=','
   while read col1 col2; do
       # do stuff
   done <<EOF
   $table
   EOF
#+END_SRC

This just stopped working with the new version and I could not figure 
out why for a long time. But I looked in the new ob-shell.el code and 
figured out that when the shell is bash it now makes an associative 
array if the variable is a table. I couldn't seem to find this 
documented anywhere.

This new behaviour seems like it would be useful in a lot of cases, but 
in my case, the tables are not key-value pairs, they are merely things I 
want to iterate over. I wonder if simply checking to see if :separator 
is set and using the old behaviour if so would be better? This would 
seem to be a fine fix which maintains backwards compatibility unless 
there is a reason to set :separator but still expect the new behaviour.

Thanks,

George.

--------------A43AA0E6EF2FB462E0963951
Content-Type: text/x-patch; name="ob-shell.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="ob-shell.patch"

diff --git a/site-lisp/org/ob-shell.el b/site-lisp/org/ob-shell.el
index 9c22af8..6f5f76e 100644
--- a/site-lisp/org/ob-shell.el
+++ b/site-lisp/org/ob-shell.el
@@ -140,7 +140,7 @@ This function is called by `org-babel-execute-src-block'."
 
 (defun org-babel--variable-assignments:bash (varname values &optional sep hline)
   "Represents the parameters as useful Bash shell variables."
-  (if (listp values)
+  (if (and (listp values) (null sep))
       (if (and (listp (car values)) (= 1 (length (car values))))
 	  (org-babel--variable-assignments:bash_array varname values sep hline)
 	(org-babel--variable-assignments:bash_assoc varname values sep hline))

--------------A43AA0E6EF2FB462E0963951--