From: Carsten Dominik <drostekirsten@gmail.com>
To: Nicolas Goaziou <n.goaziou@gmail.com>
Cc: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: [RFC] Change some defcustoms into defcont
Date: Wed, 23 Oct 2013 15:25:21 +0200 [thread overview]
Message-ID: <1C2D6C38-9B58-4989-B9A1-46869D00AFC8@gmail.com> (raw)
In-Reply-To: <87vc0otlfy.fsf@gmail.com>
Hi Nicolas, and everyone else.
I have just investigated what actually happens is someone has a
customize setting for a variable in his/her setup, and then the variable
is changed to a defconst behind his/her back. The result was very
surprising to me: customize-set-variables still does set the variable
to the stored value. Changing a different customize variable
and selecting "apply and change" updates the init file where
customize-set-variables is stored, and interestingly still preserves
the customize setting for the variable that now has become
a defconst.
This surprised me, and it seems to indicate that existing configurations
would not break.
Furthermore, I have looked at the old customization survey
at http://orgmode.org/worg/org-configs/org-customization-survey.html
It turns out that none of the variables Nicolas listed seems to have been
customized by the people participating in this survey.
Tanking these together, I am now inclined to change my view and
to let Nicolas make his proposed change.
What I would like to request is that we try to make Org still work if these
variables do in fact have a different value - but that is what Nicolas
already said.
So: IF YOU HAVE CUSTOMIZED any of this variables, I'd like to hear about it.
Otherwise, I now think that the proposal is actually good and should move ahead.
- Carsten
On Oct 23, 2013, at 10:56 AM, Nicolas Goaziou <n.goaziou@gmail.com> wrote:
> Hello,
>
> Carsten Dominik writes:
>
>> can you remind me what the bug was? The taskjuggler issue?
>
> Correct. I will fix it today.
>
>> Yes, as I said, I do see all these problems, but I also feel the responsibility
>> to break as few as possible existing configurations.
>
> I understand. Though, almost any serious change breaks some existing
> configuration. It is unfortunate, but I hope it will not prevent us from
> correcting past, and future, mistakes. Without that right to be wrong,
> we'd better plan Org development a very long time ahead and cross
> fingers hoping we will never fail. Don't cross too hard.
>
>> If you want, I can take a shot at documenting this properly.
>
> I'm not convinced by that documentation thing, i.e. "we allow you to
> change the string, but we remind you that you shouldn't do it". It even
> goes against my initial suggestion, so I cannot say I "want" anything in
> that area.
>
> Unless, that is, you're talking about a deprecation warning, e.g. "In
> future releases, this variable will not be customizable anymore, so be
> careful when changing its default value". But, IIUC, that's not what you
> want.
>
>
> Regards,
>
> --
> Nicolas Goaziou
next prev parent reply other threads:[~2013-10-23 13:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-20 8:47 [RFC] Change some defcustoms into defcont Nicolas Goaziou
2013-10-20 18:23 ` Carsten Dominik
2013-10-21 8:56 ` Nicolas Goaziou
2013-10-21 10:26 ` Carsten Dominik
2013-10-21 10:51 ` Nicolas Goaziou
2013-10-21 11:56 ` Carsten Dominik
2013-10-21 15:15 ` Nicolas Goaziou
2013-10-22 7:50 ` Carsten Dominik
2013-10-22 9:52 ` Nicolas Goaziou
2013-10-22 10:34 ` Carsten Dominik
2013-10-22 18:28 ` Torsten Wagner
2013-10-22 20:00 ` Florian Beck
2013-10-23 8:56 ` Nicolas Goaziou
2013-10-23 13:25 ` Carsten Dominik [this message]
2013-10-29 14:04 ` Nicolas Goaziou
2013-10-29 14:11 ` Nicolas Goaziou
2013-11-16 20:25 ` Nicolas Goaziou
2013-11-16 23:55 ` Carsten Dominik
2013-10-21 8:17 ` Sebastien Vauban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1C2D6C38-9B58-4989-B9A1-46869D00AFC8@gmail.com \
--to=drostekirsten@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=n.goaziou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).