From: Ivan Vilata i Balaguer <ivan@selidor.net>
To: emacs-orgmode@gnu.org
Subject: [PATCH] Trivial fix for "%3f" in URL bug
Date: Wed, 17 Mar 2010 11:53:50 +0100 [thread overview]
Message-ID: <20100317105350.GA2782@edgar.terramar.selidor.net> (raw)
[-- Attachment #1.1.1: Type: text/plain, Size: 598 bytes --]
Hi all,
Regarding the previous thread “"%3f" shouldn't be unescaped in HTTP URLs”, I
suggested that leaving the '?' or '%3f' characters in a URL as provided by the
user might be the best thing to do, since they mean different things (query
separator and literal question mark, respectively) and the user should know
best (especially if the URL was copied from a browser).
Fixing the old behaviour is trivial: just remove the ``(?? . "%3F")`` entry
from the ``org-link-escape-chars`` list in ``org.el``.
Cheers,
::
Ivan Vilata i Balaguer -- http://ivan.lovesgazpacho.net/
[-- Attachment #1.1.2: org.el.patch --]
[-- Type: text/x-diff, Size: 266 bytes --]
--- org.el.orig 2010-03-17 11:51:04.000000000 +0100
+++ org.el 2010-03-17 11:51:42.000000000 +0100
@@ -7877,7 +7877,6 @@
(?\371 . "%F9") ; `u
(?\373 . "%FB") ; ^u
(?\; . "%3B")
- (?? . "%3F")
(?= . "%3D")
(?+ . "%2B")
)
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 316 bytes --]
[-- Attachment #2: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
next reply other threads:[~2010-03-17 10:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 10:53 Ivan Vilata i Balaguer [this message]
2010-03-17 11:04 ` [PATCH] Trivial fix for "%3f" in URL bug Carsten Dominik
2010-04-19 7:34 ` Ivan Vilata i Balaguer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100317105350.GA2782@edgar.terramar.selidor.net \
--to=ivan@selidor.net \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).