From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christian Garbs <mitch@cgarbs.de>
Subject: Re: [PATCH] ob-vala.el: Add Vala support to Babel
Date: Tue, 1 Aug 2017 23:20:52 +0200
Message-ID: <20170801212052.lc64vzvuluglctqq@cgarbs.de>
References: <87fudze7y4.fsf@nicolasgoaziou.fr>
	<1500061387-3353-1-git-send-email-mitch@cgarbs.de>
	<87379no75t.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59853)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mitch@cgarbs.de>) id 1dcebA-00056p-BF
	for emacs-orgmode@gnu.org; Tue, 01 Aug 2017 17:21:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mitch@cgarbs.de>) id 1dceb7-0000K4-7d
	for emacs-orgmode@gnu.org; Tue, 01 Aug 2017 17:21:04 -0400
Received: from mail.shuttle.de ([194.95.249.4]:46126)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mitch@cgarbs.de>) id 1dceb7-0000IE-0K
	for emacs-orgmode@gnu.org; Tue, 01 Aug 2017 17:21:01 -0400
Received: from yggdrasil.mitch.h.shuttle.de (p2E5B4CF4.dip0.t-ipconnect.de
	[46.91.76.244])
	by mspool3.srv.dfn.de (Postfix) with ESMTPSA id E33451241
	for <emacs-orgmode@gnu.org>; Tue,  1 Aug 2017 23:20:53 +0200 (CEST)
Received: from mitch by yggdrasil.mitch.h.shuttle.de with local (Exim 4.89)
	(envelope-from <mitch@cgarbs.de>) id 1dceaz-0007cI-3I
	for emacs-orgmode@gnu.org; Tue, 01 Aug 2017 23:20:53 +0200
Content-Disposition: inline
In-Reply-To: <87379no75t.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: emacs-orgmode@gnu.org

Hello and sorry for the wait!

On Sun, Jul 23, 2017 at 11:05:02AM +0200, Nicolas Goaziou wrote:
> Christian Garbs <mitch@mitch.h.shuttle.de> writes:
>=20
> > * ob-vala.el: Add support for the Vala language to Babel.

> > +(defvar org-babel-vala-compiler "valac"
> > +  "Command used to compile a Vala source code file into an
> > +executable.")
>=20
> The first line of a docstring should be a full sentence.
>=20
> Also, shouldn't this be a defcustom?

Yes, it should.

Looking at the other defcustoms, is the current wording ok?
Or should it still be full a sentence?

> > +(defun org-babel-vala-table-or-string (results)
> > +  "If the results look like a table, then convert them into an
> > +Emacs-lisp table, otherwise return the results as a string."
> > +  )
>=20
> The body of the function is missing.

Not only is the body missing, the function is also not used at all, so
I have removed it altogether.  Same for org-babel-vala-var-to-vala.

> Could you send an updated patch?

Incoming :-)

Some of your proposed changes apply to ob-C.el as well.  I could
prepare a different patch for that (under which topic?), but I am not
confident that I could test the changes appropriately.  I don't have
proper C/C++/D org files handy that would cover all cases (eg. header
arguments).

Regards
Christian

PS: My FSF paperwork is complete.
--=20
....Christian.Garbs....................................https://www.cgarbs=
.de

Wie packt man Styropork=FCgelchen ein, wenn man sie verschickt?