From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Garbs Subject: Re: [PATCH] ob-vala.el: Add Vala support to Babel Date: Sun, 6 Aug 2017 12:06:12 +0200 Message-ID: <20170806100612.vfuhpjwn4glbxckh@cgarbs.de> References: <87fudze7y4.fsf@nicolasgoaziou.fr> <1500061387-3353-1-git-send-email-mitch@cgarbs.de> <87379no75t.fsf@nicolasgoaziou.fr> <20170801212052.lc64vzvuluglctqq@cgarbs.de> <87ini7q721.fsf@nicolasgoaziou.fr> <20170802202404.lltnk4rs5mt7opgw@cgarbs.de> <87vam5kjsn.fsf@nicolasgoaziou.fr> <20170805195312.srqvrch3ia3bnjqf@cgarbs.de> <87lgmxfsu0.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57208) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1deIRx-0008Cj-Ek for emacs-orgmode@gnu.org; Sun, 06 Aug 2017 06:06:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1deIRt-0007Kd-Hb for emacs-orgmode@gnu.org; Sun, 06 Aug 2017 06:06:21 -0400 Received: from mspool3.srv.dfn.de ([2001:638:d:c401::3]:59189 helo=mail.shuttle.de) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1deIRt-0007Jk-Al for emacs-orgmode@gnu.org; Sun, 06 Aug 2017 06:06:17 -0400 Received: from yggdrasil.mitch.h.shuttle.de (p2E5B481C.dip0.t-ipconnect.de [46.91.72.28]) by mspool3.srv.dfn.de (Postfix) with ESMTPSA id 6FCD2117D for ; Sun, 6 Aug 2017 12:06:14 +0200 (CEST) Received: from mitch by yggdrasil.mitch.h.shuttle.de with local (Exim 4.89) (envelope-from ) id 1deIRp-0007v9-8q for emacs-orgmode@gnu.org; Sun, 06 Aug 2017 12:06:13 +0200 Content-Disposition: inline In-Reply-To: <87lgmxfsu0.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Hello On Sun, Aug 06, 2017 at 02:22:31AM +0200, Nicolas Goaziou wrote: > Christian Garbs writes: > > Currently I run into a problem with the test case: I have created an > > org file containing some Vala code and an .el file with some tests, > > It would be better to have all tests and data self contained in the same > ".el" file, IMO. It seems I have studied the wrong tests and thought all tests were built that way :-) > I don't see any problem. The tests are meant to run if user has loaded > "ob-vala", but the test suite shouldn't load that library on user's > behalf. I just found BTEST_OB_LANGUAGES in local.mk. When I add "vala" there, "make test" will run my tests - problem solved. (I don't have (require 'ob-vala) in my .emacs as I rarely ever need it. If I need it, I put "# eval: (require 'ob-vala)" in the corresponding org file.) I fear that I am the only one who will ever run the vala tests ;-) - Are there any build hosts that automatically run the tests with all languages enabled? - Or could the BTEST_OB_LANGUAGES default in mk/default.mk be expanded to include vala? (99% of the users will simply skip the vala test because they don't have the compiler binary, so it should have no ill effacts) Regards Christian -- ....Christian.Garbs....................................https://www.cgarbs.de "We've all heard that a million monkeys banging on a million typewriters will eventually reproduce the entire works of Shakespeare. Now, thanks to the Internet, we know this is not true"