From: Maxim Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Cc: David Asabina <vid@bina.me>
Subject: Re: [PATCH] org-protocol: Fix missing '+' in js snippet
Date: Fri, 23 Apr 2021 19:21:10 +0700 [thread overview]
Message-ID: <41e021be-e973-652b-fd04-b1b4524b959b@gmail.com> (raw)
In-Reply-To: <20210419105316.10227-1-vid@bina.me>
On 19/04/2021 17:53, David Asabina wrote:
>
> javascript:location.href = \\='org-protocol://capture?url=\\='+ \\
> - encodeURIComponent(location.href) + \\='&title=\\=' \\
> + encodeURIComponent(location.href) + \\='&title=\\=' + \\
> encodeURIComponent(document.title) + \\='&body=\\=' + \\
> encodeURIComponent(window.getSelection())
I am not a maintainer, so I can not merge the patch. I hope, finally it
will happen, maybe some months later.
I have a question that is a bit off-topic in this thread however. Since
you are setting up org-protocol, you may notice other issues. There were
reports that two slashes after "org-protocol:" cause some problems. My
guess is that capture is recognized as hostname, so another slash is
inserted after it. There was a patch allowing "/" before "?" to get
things work (perhaps on Windows). Could you try, please, if one or three
slashes in org-protocol URIs ("org-protocol:/capture?url=..." and
"org-protocol:///capture?url=...") works properly in your environment?
Maybe code examples in docs would benefit from one more correction.
next prev parent reply other threads:[~2021-04-23 12:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 10:53 [PATCH] org-protocol: Fix missing '+' in js snippet David Asabina
2021-04-23 12:21 ` Maxim Nikulin [this message]
2021-04-28 5:40 ` Bastien
2021-04-28 12:42 ` Maxim Nikulin
2021-04-30 7:21 ` Bastien
2021-05-02 11:34 ` Maxim Nikulin
[not found] ` <20210503152514.bx5gghrqjr3vmxd7@bina>
[not found] ` <cd274ad0-488e-8b52-aef0-87a2e95c8b85@gmail.com>
2021-05-08 22:32 ` David Asabina
2021-04-28 5:38 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41e021be-e973-652b-fd04-b1b4524b959b@gmail.com \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=vid@bina.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).