emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Simon Thum <simon.thum@gmx.de>
To: Kyle Meyer <kyle@kyleam.com>
Cc: Bastien <bzg@gnu.org>, emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Regression in Org triggered from helm
Date: Tue, 27 Oct 2015 21:48:19 +0000	[thread overview]
Message-ID: <562FF123.2070306@gmx.de> (raw)
In-Reply-To: <877fm9bb40.fsf@kyleam.com>


On 10/26/15 20:58, Kyle Meyer wrote:
> Hello,
>
> Simon Thum <simon.thum@gmx.de> writes:
>
>> Hi,
>>
>> after updating helm I came across a possible regression on Org. I
>> Already filed a helm bug, but Thierry thinks it's Org's fault.
>
> What version of Org are you using?

Org-mode 8.3.2 - I just upgraded from 8.3 beta hoping to fix this.

>
>> https://github.com/emacs-helm/helm/issues/1246
>>
>> In short, M-x helm-org-agenda-files-headings breaks.
>>
>> I had some success working around it, but for reasons beyond me that
>> doesn't work any more. I'll try to work out a MCE but for the time in
>> between, maybe someone has an idea what's wrong, and where (org or
>> helm)?
>
> I haven't had any luck reproducing this.  Isolating the error with a
> minimal configuration and minimal Org file would be very helpful.

I know, but ATM my time is limited. I tried to debug but only got as far as

Edebug: edebug-anon74105
edebug-signal: Symbol's value as variable is void: Debugger

At which point I figured reporting the bug might be sensible enough.

>
>>
>> Here is the complete stacktrace (the -my function is textually
>> equivalent to its non-my counterpart in helm-org):
>>
>>
>> Debugger entered--Lisp error: (args-out-of-range "LoD" 0 -3)
>>    substring("LoD" 0 -6)
>>    (setq h (substring h 0 (- maxwidth 2)) total (+ total maxwidth 1))
>
> At some point, maxwidth is being set very low (-4 here).  Try to see
> where this happens.  For example, what value for width does
> helm-get-org-candidates-in-file send into org-format-outline-path?  If
> that seems to be appropriate, debug org-format-outline-path and see when
> it's getting set to the low value.

Arrgh - you're on the spot. That explains a lot, including my 
difficulties with reproducing.

It sends window-width. Increase to window(-width) and I'm done.

But that means it's arguably Org which should be more graceful than it 
is. Bastien, I cc'ed you as the maintainer, I guess you know who's best 
qualified to fix this.

Thanks for your input Kyle!

Cheers,

Simon	

  reply	other threads:[~2015-10-26 21:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 20:22 Regression in Org triggered from helm Simon Thum
2015-10-26 20:58 ` Kyle Meyer
2015-10-27 21:48   ` Simon Thum [this message]
2015-10-26 22:40     ` Kyle Meyer
2015-10-28  6:29       ` Kyle Meyer
2015-10-28 13:34         ` Nicolas Goaziou
2015-10-31 12:14           ` Simon Thum
2015-10-31 16:50           ` Simon Thum
2015-10-30 17:32             ` Kyle Meyer
2015-10-31 16:56               ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562FF123.2070306@gmx.de \
    --to=simon.thum@gmx.de \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=kyle@kyleam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).