From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WDRdFsf6f1+yRgAA0tVLHw (envelope-from ) for ; Fri, 09 Oct 2020 05:53:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id oLNJEsf6f1/uDwAAB5/wlQ (envelope-from ) for ; Fri, 09 Oct 2020 05:53:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A85649402A0 for ; Fri, 9 Oct 2020 05:53:10 +0000 (UTC) Received: from localhost ([::1]:51242 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQlL2-0006YJ-Rc for larch@yhetil.org; Fri, 09 Oct 2020 01:53:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQlJ8-0006VO-Ee for emacs-orgmode@gnu.org; Fri, 09 Oct 2020 01:51:10 -0400 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]:46412) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQlJ2-0002sX-Iz for emacs-orgmode@gnu.org; Fri, 09 Oct 2020 01:51:09 -0400 Received: by mail-ed1-x52c.google.com with SMTP id 33so8072290edq.13 for ; Thu, 08 Oct 2020 22:51:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ubedi-net.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=vIJsn8sHtkIhrz3qy+TRIPgUWYheg9M66lBER0MhjTg=; b=B1VZPIftLA9+EeUHM5vWwF6J6NqfgGSy+hTM5frInxghg22+S9NOYyG2DOxNJU588b 3IQ+WhMrA2k8EAjgclhtx9zvtZgwndluBIFZUnrYBiAsPeOC0taUh7rABwZ/K4FILc/7 E9XUGPddDmVKf0GKwRjkntaiDt76DwP9rjo0xc+HJojDX9DTWyvqRSjtqxjcL53Y3zm9 N6DbvFWr6PfUZ4Lp7F0z3lr9qX5tH4XjMlloZzZkMH922oa8dxHvXZcqPX+AA7faRTSh E62BSFJJAh9HPxfm8EV6TQZT8t1R+g/O3Sae7dVUJUf2Gy40uuCaAZGFjPf/ZwW6XqQw eBsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=vIJsn8sHtkIhrz3qy+TRIPgUWYheg9M66lBER0MhjTg=; b=WXySxjXPDbrgX3bY+PeW2NApqdkSeIfEXKBM4fyBnn9nD1dZAWHePzz+kydhR9abxW 2IwXEeNX5YwzpQ1b31q/Zw1h6JdsPaWK9u1Nm7CuqglBuOKJVH21nZUvRJEVEwSF9bcZ J8a6ZAgZnlEJ5xQyf2z45zLozzRyE9XJ0KrSZ+83AKkYG+4L9NDcyYYMFX4gh+X497jD 9r4jv041elmqmdsHE/ytj1yQgA27grdbPnOJxk5nAo1qE6r0jtLDNI/uHrAWNzRA1+O+ PBN7ueiFoy75+2MCMBenUEXK3eXUG/qqQB1PJS/Sv9fSJdkGreKpXOJFF9N/xQXrvfTA 2btg== X-Gm-Message-State: AOAM531sDw/8ThwMJsfW0BPWKvFrCSEJfCIc6W6IpbBLrbvzLlemJwmN U0Q5iAmmgHvZPUJt3FBMXmk8K0jCwu0s/Sab X-Google-Smtp-Source: ABdhPJwzn5ErKxyHQZXYw2JxiozMxnUgk5HRl0FMpVnC0UiK4fGFoCorWjDXFSdrZ7vI4XpegciEMg== X-Received: by 2002:aa7:cd85:: with SMTP id x5mr13286210edv.0.1602222660448; Thu, 08 Oct 2020 22:51:00 -0700 (PDT) Received: from gt1.localnet (ip-4-221.hlucinnet.cz. [93.91.243.221]) by smtp.gmail.com with ESMTPSA id x2sm5527732edr.65.2020.10.08.22.50.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2020 22:50:59 -0700 (PDT) From: Martin Kampas To: emacs-orgmode@gnu.org Subject: Bug: Incorrect done TODO keywords highlighting in column view Date: Fri, 09 Oct 2020 07:50:58 +0200 Message-ID: <7117090.b6naEkYVYe@gt1> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="nextPart3920592.nDWQM99Tsl" Content-Transfer-Encoding: 7Bit Received-SPF: pass client-ip=2a00:1450:4864:20::52c; envelope-from=martin.kampas@ubedi.net; helo=mail-ed1-x52c.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=ubedi-net.20150623.gappssmtp.com header.s=20150623 header.b=B1VZPIft; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.21 X-TUID: BPQJ5SKJs6sL This is a multi-part message in MIME format. --nextPart3920592.nDWQM99Tsl Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi, In columns view, all TODO keywords except those with face set explicitly with org-todo- keyword-faces are red. Done keywords should be green. Patch below. BR, Martin >From a4df0da1057afbe90ea0e457158082b15386a164 Mon Sep 17 00:00:00 2001 From: Martin Kampas Date: Fri, 9 Oct 2020 07:43:17 +0200 Subject: [PATCH] org-colview: Fix done TODO keywords highlighting * lisp/org-colview.el (org-columns--overlay-text): Populate org-done-keywords from org-done-keywords-for-agenda or the done keywords will use the same face as not-done keywords. --- lisp/org-colview.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/org-colview.el b/lisp/org-colview.el index e50a4d7c8..827f57e5e 100644 --- a/lisp/org-colview.el +++ b/lisp/org-colview.el @@ -365,7 +365,9 @@ ORIGINAL is the real string, i.e., before it is modified by org-tags-special-faces-re (lambda (m) (propertize m 'face (org-get-tag-face m))) v nil nil 1))) - ("TODO" (propertize v 'face (org-get-todo-face original))) + ("TODO" + (let ((org-done-keywords org-done-keywords-for-agenda)) + (propertize v 'face (org-get-todo-face original)))) (_ v))))) (defvar org-columns-header-line-remap nil -- 2.28.0 --nextPart3920592.nDWQM99Tsl Content-Transfer-Encoding: 7Bit Content-Type: text/html; charset="us-ascii"

Hi,


In columns view, all TODO keywords except those with face set explicitly with org-todo-keyword-faces are red. Done keywords should be green.


Patch below.


BR,

Martin


From a4df0da1057afbe90ea0e457158082b15386a164 Mon Sep 17 00:00:00 2001

From: Martin Kampas <martin.kampas@ubedi.net>

Date: Fri, 9 Oct 2020 07:43:17 +0200

Subject: [PATCH] org-colview: Fix done TODO keywords highlighting


* lisp/org-colview.el (org-columns--overlay-text): Populate

org-done-keywords from org-done-keywords-for-agenda or the done keywords

will use the same face as not-done keywords.

---

 lisp/org-colview.el | 4 +++-

 1 file changed, 3 insertions(+), 1 deletion(-)


diff --git a/lisp/org-colview.el b/lisp/org-colview.el

index e50a4d7c8..827f57e5e 100644

--- a/lisp/org-colview.el

+++ b/lisp/org-colview.el

@@ -365,7 +365,9 @@ ORIGINAL is the real string, i.e., before it is modified by

                   org-tags-special-faces-re

                   (lambda (m) (propertize m 'face (org-get-tag-face m)))

                   v nil nil 1)))

-              ("TODO" (propertize v 'face (org-get-todo-face original)))

+              ("TODO"

+               (let ((org-done-keywords org-done-keywords-for-agenda))

+                 (propertize v 'face (org-get-todo-face original))))

               (_ v)))))

 

 (defvar org-columns-header-line-remap nil

--

2.28.0



--nextPart3920592.nDWQM99Tsl--