From mboxrd@z Thu Jan  1 00:00:00 1970
From: Carsten Dominik <carsten.dominik@gmail.com>
Subject: Re: Re: Support (or not) for Emacs 21, and XEmacs
Date: Mon, 19 Apr 2010 17:51:22 +0200
Message-ID: <77B2163B-B119-4E59-B834-58469C2BF6FC@gmail.com>
References: <15649C3E-517D-433D-977F-06008C20A4F4@gmail.com>
	<y9ld3xy6qcq.fsf@deinprogramm.de>
	<A707345D-BFD9-4191-B861-23FEAAA800B9@gmail.com>
	<y9ly6gl5fwh.fsf@deinprogramm.de>
	<3658A4B7-E30A-4D7A-9781-C97A01931A13@gmail.com>
	<y9l4oj7672m.fsf@deinprogramm.de> <y9laaszsna0.fsf@deinprogramm.de>
Mime-Version: 1.0 (Apple Message framework v936)
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O3tHP-0007GG-BH
	for emacs-orgmode@gnu.org; Mon, 19 Apr 2010 11:52:59 -0400
Received: from [140.186.70.92] (port=56388 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O3tHM-0007EO-86
	for emacs-orgmode@gnu.org; Mon, 19 Apr 2010 11:52:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <carsten.dominik@gmail.com>) id 1O3tHF-0005zD-4E
	for emacs-orgmode@gnu.org; Mon, 19 Apr 2010 11:52:55 -0400
Received: from mail-bw0-f225.google.com ([209.85.218.225]:49519)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <carsten.dominik@gmail.com>) id 1O3tHE-0005z1-Qt
	for emacs-orgmode@gnu.org; Mon, 19 Apr 2010 11:52:49 -0400
Received: by bwz25 with SMTP id 25so4892567bwz.8
	for <emacs-orgmode@gnu.org>; Mon, 19 Apr 2010 08:52:47 -0700 (PDT)
In-Reply-To: <y9laaszsna0.fsf@deinprogramm.de>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Michael Sperber <sperber@deinprogramm.de>
Cc: emacs-orgmode@gnu.org


On Apr 19, 2010, at 1:19 PM, Michael Sperber wrote:

>
> One more thing: Are patches like this one acceptable? (Needed to make
> yesterday's checkout work on XEmacs)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 7cad962..5cca11e 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -17743,7 +17743,7 @@ the functionality can be provided as a fall- 
> back.")
>   (org-set-local 'fill-paragraph-function 'org-fill-paragraph)
>   ;; Adaptive filling: To get full control, first make sure that
>   ;; `adaptive-fill-regexp' never matches.  Then install our own  
> matcher.
> -  (unless (local-variable-p 'adaptive-fill-regexp)
> +  (unless (local-variable-p 'adaptive-fill-regexp (current-buffer))
>     (org-set-local 'org-adaptive-fill-regexp-backup
>                    adaptive-fill-regexp))
>   (org-set-local 'adaptive-fill-regexp "\000")

That is acceptable - but I think that making BUFFER default to  
(current-buffer)
does make a lot of sense - which is why making that argument optional  
in XEmacs
is a good idea anyway.

- Carsten