From: Bastien <bzg@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Dan Drake <dan.drake@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: [RFC PATCH] specify a time, not number of minutes to keep, with org-resolve-clock
Date: Sat, 01 Feb 2020 15:34:54 +0100 [thread overview]
Message-ID: <8736bu9y0h.fsf@bzg.fr> (raw)
In-Reply-To: 87h80acs29.fsf@nicolasgoaziou.fr
Hi Nicolas,
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Bastien <bzg@gnu.org> writes:
>
>> My point is that distinguishing trivial vs. non-trivial parts of a
>> change may be subject to interpretation. When in doubt, I recommend
>> staying on the safe side of not accepting a change that is more than
>> 15 lines of "maybe-significant" changes.
>
> AFACT, there was no doubt involved when I said "15 lines of non-trivial
> code".
I'm sure there was no doubt on your side, but as the one responsible
for the consistency of copyright assignment for Org-mode, my attention
is necessarily triggered when I see a change of >20 lines marked as
"tiny change".
I fully trust your judgement. I am not arguing that *this* change
required Dan to sign the papers. I'm saying that in general, I would
rather avoid relying on the evaluation of the "triviality" of the locs
and incite contributors to sign the papers.
> If your point (I didn't get it actually) is "interpretation is hard,
> let's not interpret anything and count everything as significant", well,
> I think this is not a good way to look at the problem. But that's fine,
> as long as it suits you.
My point is this: the inconveniency of *systematically* requesting
copyright assignment from the contributor when its contribution is
more than 15 lines (significant *or not*) is a small inconveniency
compared to the one of having to check carefully whether every >15
lines change is significant or not.
And since is it a good outcome to have more people signing the FSF
papers, I recommend requesting contributors to sign the copyright
assignment for every >15 lines contributions (significant or not).
Future maintainers may of course interpret the recommendations of
the FSF differently, but that's mine for now.
Thanks,
--
Bastien
next prev parent reply other threads:[~2020-02-01 14:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 20:13 [RFC PATCH] specify a time, not number of minutes to keep, with org-resolve-clock Dan Drake
2020-01-24 23:30 ` Nicolas Goaziou
2020-01-29 2:11 ` Dan Drake
2020-01-29 9:49 ` Nicolas Goaziou
2020-01-29 12:47 ` Bastien
2020-02-01 10:22 ` Nicolas Goaziou
2020-02-01 13:10 ` Bastien
2020-02-01 14:15 ` Nicolas Goaziou
2020-02-01 14:34 ` Bastien [this message]
2020-02-01 16:48 ` Nicolas Goaziou
2020-02-02 13:41 ` Dan Drake
2020-02-02 13:51 ` Bastien
2020-02-03 14:41 ` Robert Pluim
2020-02-03 14:53 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736bu9y0h.fsf@bzg.fr \
--to=bzg@gnu.org \
--cc=dan.drake@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).