From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Why does quote and verse block fontification have to override local fontification? Date: Wed, 22 Feb 2017 11:51:02 +0100 Message-ID: <8737f6h52h.fsf@nicolasgoaziou.fr> References: <871suqtuxy.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cgUVu-0004hs-Lx for emacs-orgmode@gnu.org; Wed, 22 Feb 2017 05:51:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cgUVt-0005Rs-Rl for emacs-orgmode@gnu.org; Wed, 22 Feb 2017 05:51:14 -0500 Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:35569) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cgUVt-0005Rg-Ll for emacs-orgmode@gnu.org; Wed, 22 Feb 2017 05:51:13 -0500 In-Reply-To: <871suqtuxy.fsf@gmail.com> (Anders Johansson's message of "Wed, 22 Feb 2017 10:51:21 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Anders Johansson Cc: emacs-orgmode@gnu.org Hello, Anders Johansson writes: > I want to fontify quote blocks (i use them a lot for note taking and > writing paper) so that they stand out (and so I enable > org-fontify-quote-and-verse-blocks) but it would be useful to preserve > the local fontification of emphasis, links etc. inside quote blocks. > This can easily be achieved with a patch like this org.el: > > 6096,6099c6096,6099 > < ((string= block-type "quote") > < (add-face-text-property beg1 (min (point-max) (1+ end1)) > 'org-quote t)) > < ((string= block-type "verse") > < (add-face-text-property beg1 (min (point-max) (1+ end1)) > 'org-verse t))) > --- >> ((string= block-type "quote") >> (add-text-properties beg1 (min (point-max) (1+ end1)) >> '(face org-quote))) >> ((string= block-type "verse") >> (add-text-properties beg1 (min (point-max) (1+ end1)) >> '(face org-verse)))) > > > In this invocation add-face-text-property appends org-quote to the > face property, and hence all other fontification is kept. > > Does this interfere with something else or what people would expect? > In my view it looks much better, but I guess that can depend on the > appearance of org-quote and org-verse (I have them as > font-lock-comment-face, just a slightly different colour, on top of > which italics etc. look good). Sounds good. Could you provide a patch using git format-patch command? Please add TINYCHANGE at the end of the commit message if you haven't signed FSF copyright papers. Thank you. Regards, -- Nicolas Goaziou