From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +GH/D4irwGDIHQAAgWs5BA (envelope-from ) for ; Wed, 09 Jun 2021 13:52:40 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id wFE9C4irwGB3XgAAbx9fmQ (envelope-from ) for ; Wed, 09 Jun 2021 11:52:40 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3E1A72B353 for ; Wed, 9 Jun 2021 13:52:39 +0200 (CEST) Received: from localhost ([::1]:53630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqwlA-0000sy-PH for larch@yhetil.org; Wed, 09 Jun 2021 07:52:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34332) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqwkm-0000lq-W2 for emacs-orgmode@gnu.org; Wed, 09 Jun 2021 07:52:13 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:49591) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqwkk-00005t-P0 for emacs-orgmode@gnu.org; Wed, 09 Jun 2021 07:52:12 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id E17A140009; Wed, 9 Jun 2021 11:52:05 +0000 (UTC) From: Nicolas Goaziou To: Timothy Subject: Re: [PATCH] Allow LaTeX reference command (\ref) to be customised References: <87mts25000.fsf@gmail.com> <871r9bpz18.fsf@gmail.com> Mail-Followup-To: Timothy , org-mode-email Date: Wed, 09 Jun 2021 13:52:04 +0200 In-Reply-To: <871r9bpz18.fsf@gmail.com> (Timothy's message of "Wed, 09 Jun 2021 10:11:47 +0800") Message-ID: <874ke7i7bv.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.194; envelope-from=mail@nicolasgoaziou.fr; helo=relay2-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: org-mode-email Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1623239560; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=RE496gWeZ+B0gh51CVPZxZX2SPnOxwnnc2Pu10lLPAI=; b=HuXyK+HDJ3oB1Bz3GkGLDs18Tm/LdR+fhfxOai/dNSpcq4tbGrPBrMWT4uEu2ih6xtviXo VEASEFmUIIWnkwQtK2ZI7hGJUVP1Kk7Pni9GcGI0FIF0lOjkKEbv2M5xutvh4cglHg1Ef2 XV3q6r3/0AYgK6qEPp7mHFZfiG3nf3LTLF5mj2xVKMJjUmWLo1e0pYlg6TfZ73eLTBwWiz d2PhC7m8Cax50D4rlCD2AsofB+ejAUfli4QZgRXKpjAM0xSGvQr59kaHlR7GACrwELi9Yb 2E6YJrR5xIdu3kSo5t6HWodgaK9dH6FRVmFELAvOIpWywvKR0fNNkhwfx2mwxw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1623239560; a=rsa-sha256; cv=none; b=j6oO98/ze5tcUaG6e653M/EaqjNJ2zczxlcF9cV4F3oJhpjZmpeyvy7VPZ0FYe148uBGxn azFTxYYom1p3tJRb/kiw7BROdl+8e7zgbF6+uRNIYqcTE2eNWD694AVf3Lz3OgwB8xC+Du zYtDOqjKUSaRr4bln0E8vOD8ZyVPxLHEH21D3Ej5ntajDJTlrx+E3/TyzOxVYT4sVcW/hD 6pRoerme8XF0iFYW3fomADf2N2Voti4Jm55ssH+qhMhe2Z5n98BrRs8UPJ/HQ125rm6Y8o FXI7Zx9yoESKB8C6ePBwakMTDgoTKssUs8x6pesmMQq5ZVWgaE0QtXasa8Iv0Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.43 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 3E1A72B353 X-Spam-Score: -2.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: WrzRWZAquqR6 Hello, Timothy writes: > I'm wondering if you've had a chance to take a look yet? (just making > sure this hasn't slipped by, given your recent replies in other > threads). I agree there is no good reason to hard-code "\ref", but, off the top of my head, there may be a couple of things to consider: 1. There is still a dangling \ref in `org-latex-footnote-defined-format'; 2. This change is already somewhat trivial using a link filter: (defun my-ref-link-filter (s &rest _) (replace-regexp-in-string (rx string-start "\\ref") "\\foo" s nil t)) (add-to-list 'org-export-filter-link-functions #'my-ref-link-filter) 3. \hyperref is still hard-coded in `org-latex-link'; your patch could look like a partial solution. Those are not strong objections, so if you think none of them is worth considering, then I'm fine with your patch. Regards, -- Nicolas Goaziou