From: David Florness <david@florness.com> To: emacs-orgmode@gnu.org Subject: [PATCH] org-contacts.el: Only use org-id-store-link if org-id is loaded Date: Sun, 03 Jan 2021 18:09:18 -0500 Message-ID: <874kjxpqht.fsf@florness.com> (raw) [-- Attachment #1: Type: text/plain, Size: 1080 bytes --] Fixes bug introduced in 6b83c6e4e that made org-contacts-anniversaries error if org-id was not loaded. --- Alternatively, we could autoload org-id-link-to-org-use-id. If you all would prefer this, let me know and I can send a v2 patch. 6b83c6e4e was found using git-blame. contrib/lisp/org-contacts.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/lisp/org-contacts.el b/contrib/lisp/org-contacts.el index 82881ecd0..7ad425519 100644 --- a/contrib/lisp/org-contacts.el +++ b/contrib/lisp/org-contacts.el @@ -1166,7 +1166,7 @@ are effectively trimmed). If nil, all zero-length substrings are retained." "Store the contact in `org-contacts-files' with a link." (when (and (eq major-mode 'org-mode) (member (buffer-file-name) (mapcar 'expand-file-name org-contacts-files))) - (if org-id-link-to-org-use-id + (if (and (featurep 'org-id) org-id-link-to-org-use-id) (org-id-store-link) (let ((headline-str (substring-no-properties (org-get-heading t t t t)))) (org-store-link-props -- 2.30.0 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 511 bytes --]
next reply other threads:[~2021-01-03 23:43 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-03 23:09 David Florness [this message] 2021-01-04 3:44 ` miles christopher 2021-01-04 4:15 ` David Florness 2021-01-04 17:33 ` miles christopher 2021-01-04 18:13 ` David Florness 2021-01-04 18:21 ` David Florness 2021-01-05 3:09 ` [PATCH v2] " David Florness 2021-01-05 3:56 ` Kyle Meyer 2021-01-05 4:20 ` [PATCH] org-contacts.el: Use `bound-and-true-p' to check (unbound) var David Florness 2021-01-05 5:06 ` Kyle Meyer 2021-01-05 11:33 ` miles christopher
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://orgmode.org * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=874kjxpqht.fsf@florness.com \ --to=david@florness.com \ --cc=emacs-orgmode@gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Org-mode mailing list This inbox may be cloned and mirrored by anyone: git clone --mirror https://orgmode.org/list/0 list/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 list list/ https://orgmode.org/list \ emacs-orgmode@gnu.org public-inbox-index list Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.yhetil.org/yhetil.emacs.orgmode nntp://news.gmane.io/gmane.emacs.orgmode AGPL code for this site: git clone https://public-inbox.org/public-inbox.git