From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2A7YJ7UvsF77ZAAA0tVLHw (envelope-from ) for ; Mon, 04 May 2020 15:07:33 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id OAfuMcAvsF7uTQAAbx9fmQ (envelope-from ) for ; Mon, 04 May 2020 15:07:44 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B11DB945B16 for ; Mon, 4 May 2020 14:56:53 +0000 (UTC) Received: from localhost ([::1]:50318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVcWc-0003me-3U for larch@yhetil.org; Mon, 04 May 2020 10:56:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVcQm-0001DZ-6T; Mon, 04 May 2020 10:50:52 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:47899) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVcQk-00044N-GJ; Mon, 04 May 2020 10:50:51 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 9F91620002; Mon, 4 May 2020 14:50:43 +0000 (UTC) From: Nicolas Goaziou To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Subject: Re: Reconciling org-mode idiosyncrasies with Emacs core References: <20200426172206.GC18629@ACM> <87y2qhnc9a.fsf@gmail.com> <20200427102311.GA4976@ACM> <87mu6xtano.fsf@gmail.com> <87k120ohsq.fsf@mail.linkov.net> <87blnbir01.fsf@nicolasgoaziou.fr> <87o8rbmbfa.fsf@mail.linkov.net> <87k11yftqo.fsf@nicolasgoaziou.fr> <87pnbqo74t.fsf_-_@gmail.com> <87ees6fp8r.fsf@nicolasgoaziou.fr> <87y2q89dx7.fsf@gmail.com> Mail-Followup-To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec , Juri Linkov , Org Mode list , Emacs developers Date: Mon, 04 May 2020 16:50:42 +0200 In-Reply-To: <87y2q89dx7.fsf@gmail.com> (=?utf-8?Q?=22K=C3=A9vin?= Le Gouguec"'s message of "Mon, 04 May 2020 12:45:24 +0200") Message-ID: <874ksv4uv1.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=217.70.183.200; envelope-from=mail@nicolasgoaziou.fr; helo=relay7-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 10:50:44 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emacs developers , Org Mode list , Juri Linkov Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 X-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Scan-Result: default: False [-1.01 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49487279176906]; HAS_XOIP(0.00)[]; DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.13), country: US(-0.00), ip: 2001:470:142::17(-0.49)]; TO_DN_ALL(0.00)[]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; MAILLIST(-0.20)[mailman]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; FROM_NEQ_ENVFROM(0.00)[mail@nicolasgoaziou.fr,emacs-orgmode-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[nicolasgoaziou.fr]; HAS_LIST_UNSUB(-0.01)[]; MIME_TRACE(0.00)[0:+]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: O/brbYOGhl/X Hello, K=C3=A9vin Le Gouguec writes: > I took a stab at making RET obey electric-indent-mode in org-mode. Thank you! > I've got something working; I'd like to ask for a review before moving > on to Changelog and ORG-NEWS entries (and tackling C-j=E2=80=A6 and maybe > writing a few unit tests?). Tests for `org-return' (named "test-org/return") are in the "test-org.el" file in the "testing/lisp" directory. We only need to test if electric-indent-mode has an effect, but only in regular cases. > Here's the patch, with some additional comments below: It looks good. > - INTERACTIVE is what makes 'newline' run 'post-self-insert-hook' (thus > triggering indentation through electric-indent-mode), OK. I thought it was necessary to call `electric-newline-and-maybe-indent'. > - ARG wasn't strictly necessary, but it seemed harmless to add it, and > it allows inserting multiple newlines, thus removing one more "Org > idiosyncrasy". Good idea. > I felt that introducing org--newline made the code clearer, but I can > understand if it seems too trivial to keep. No, that's fine. > I took the liberty of using > this function in the "list item" case too, otherwise there's no way to > indent the trailing text. I'm not sure what you mean. It would be a regression if you didn't use the function there, too, wouldn't it? > (Out of curiosity, could it be argued that this is solving a "bug" in > org-mode and, as such, could be committed to Emacs core first, then > backported to the org-mode repository? I don't feel strongly either > way, I wouldn't want to make things more complicated for Org > maintainers.) I cannot speak for the Emacs side, but it should land in Org 9.4, not Org 9.3.6. It is a very visible change, one that every Org user is going to face. This requires a new ORG-NEWS entry. Those only appear in new minor+ releases. Therefore, if you apply it in Emacs 27.1, the change will be announced nowhere. > Now for C-j, in order to minimize breakage (for anyone calling > org-return-indent from Lisp code) and simplify disabling the new > behaviour (by simply turning off electric-indent-mode in Org), should we > bind C-j to a new function? E.g.: > > (defun org-return-and-maybe-indent () > (interactive) > (org-return (not electric-indent-mode))) I think so. Then we can mark `org-return-indent' as obsolete and suggest to call `org-return' instead. Regards, --=20 Nicolas Goaziou