emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Lambda Coder <sjlambda@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: org.texi edits, patch attached
Date: Fri, 11 Nov 2016 11:18:27 +0100	[thread overview]
Message-ID: <874m3efhfw.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAM5gNT1FV4c2SVUFWwT3Z6N0bL1rV4=qVHgu3HLeDmYEsvx5tA@mail.gmail.com> (Lambda Coder's message of "Mon, 7 Nov 2016 15:30:51 -0800")

Hello,

Lambda Coder <sjlambda@gmail.com> writes:

> Attached is a patch submission for org.texi file. Sorry for the large size
> of the attachment. I am posting to this list on Bastien's suggestion.
>
> The edits mainly pertain to org-babel, which is where most of my time is
> spent these days. This patch is an attempt to make the documentation more
> consistent with the rest of gnu manuals. Comments and suggestions
> welcome.

Thank you for the patch!

I didn't read through the whole set of changes but I'll make some
initial comments.

Have you signed FSF papers already? You need to so that we can apply
your non-trivial changes to documentation.

Also, Texinfo document requires two spaces after a full stop. There are
a couple of places in your changes that do not follow this.

You also need to provide a proper commit message, listing sections
modified in the manual. See commit message in the repo for examples.

If your FSF papers are in order, could you send an updated patch?


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2016-11-11 10:18 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-07 23:30 org.texi edits, patch attached Lambda Coder
2016-11-11 10:18 ` Nicolas Goaziou [this message]
2016-11-11 13:38   ` Bastien Guerry
2016-11-14 12:02   ` Lambda Coder
2016-11-15  7:47     ` Nicolas Goaziou
2016-11-15 20:10       ` Lambda Coder
2016-11-15 20:44         ` Nicolas Goaziou
2016-11-16 23:30           ` Lambda Coder
2016-11-17 22:56             ` Nicolas Goaziou
2016-11-18  0:51               ` Lambda Coder
2016-11-18  8:21                 ` Nicolas Goaziou
2016-11-19  4:09                   ` Lambda Coder
2016-11-24  1:46                     ` Lambda Coder
2016-11-26 22:42                       ` Nicolas Goaziou
2016-12-02 20:33                         ` Lambda Coder
2016-12-03 23:46                           ` Nicolas Goaziou
2016-12-15  6:45                             ` Lambda Coder
2016-12-18 23:39                               ` Nicolas Goaziou
2016-12-20  3:31                                 ` Lambda Coder
2016-12-20 16:58                                   ` Nicolas Goaziou
2017-02-23 13:24                                     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874m3efhfw.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=sjlambda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).