From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric S Fraga Subject: [bug] alias for list-diary-entries-hook creates loop in emacs 24 Date: Wed, 11 Jan 2012 08:56:56 +0000 Message-ID: <874nw262hz.fsf@ucl.ac.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([140.186.70.92]:52810) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkuXw-0007QQ-6S for emacs-orgmode@gnu.org; Wed, 11 Jan 2012 04:32:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RkuXo-0000HS-T6 for emacs-orgmode@gnu.org; Wed, 11 Jan 2012 04:32:40 -0500 Received: from vscani-b2.ucl.ac.uk ([144.82.108.135]:46185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkuXo-0000H1-Ou for emacs-orgmode@gnu.org; Wed, 11 Jan 2012 04:32:32 -0500 Received: from dip057.chemeng.ucl.ac.uk ([128.40.228.156] helo=localhost) by vscani-b.ucl.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.76) (envelope-from ) id 1RkuXl-00062D-OK for emacs-orgmode@gnu.org; Wed, 11 Jan 2012 09:32:29 +0000 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Hello, one of the recent updates commit d6e40fb3472761ed51795f54491b969976167116 to org has caused a problem with the latest emacs snapshot (version from 5 January I believe). Specifically, the alias for list-diary-entries-hook would appear to create an alias loop as diary-lib.el in emacs already has an alias. Removing two lines from org-agenda.el (patch attached) fixes the problem (for me). I am not suggesting this as a patch as it would appear that an emacs version specific check should probably be made? I don't know enough about this to suggest a proper solution unfortunately. thanks, eric --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=remove-diary-list-entries-hook-alias.patch Content-Description: remove var alias for list-diary-entries-hook diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index 28f5429..bdf6881 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -4378,8 +4378,6 @@ of what a project is and how to check if it stuck, customize the variable (defvar org-disable-agenda-to-diary nil) ;Dynamically-scoped param. (defvar diary-list-entries-hook) -(if (fboundp 'defvaralias) - (defvaralias 'diary-list-entries-hook 'list-diary-entries-hook)) (defvar diary-time-regexp) (defun org-get-entries-from-diary (date) "Get the (Emacs Calendar) diary entries for DATE." --=-=-= Content-Type: text/plain -- : Eric S Fraga (GnuPG: 0xC89193D8FFFCF67D) in Emacs 24.0.90.1 : using Org-mode version 7.8.03 (release_7.8.03.75.g7e08.dirty) --=-=-=--