From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CDLfNidIzl8bRwAA0tVLHw (envelope-from ) for ; Mon, 07 Dec 2020 15:20:07 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id sPCpMidIzl/uHwAAB5/wlQ (envelope-from ) for ; Mon, 07 Dec 2020 15:20:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B793294038E for ; Mon, 7 Dec 2020 15:20:07 +0000 (UTC) Received: from localhost ([::1]:55870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmIJ3-0002cG-V1 for larch@yhetil.org; Mon, 07 Dec 2020 10:20:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmIGN-0000QY-O7 for emacs-orgmode@gnu.org; Mon, 07 Dec 2020 10:17:19 -0500 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]:33350) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kmIGL-0001I3-MV for emacs-orgmode@gnu.org; Mon, 07 Dec 2020 10:17:19 -0500 Received: by mail-pf1-x42a.google.com with SMTP id p4so4407921pfg.0 for ; Mon, 07 Dec 2020 07:17:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=ySBqG1B4zvvcQQ/fe2eFp1tNS620vXvYDTgjfYHiu/c=; b=RDXmC14BlwMHg16KBvtjmHB2N7bC6B0zCDVQOo+Z1owD8LLmpdZDeZ98v48fXMuGMD 2fyImcQPyqPgi8vigqMv/Gc6JdR+76BpsduSeQrfINZk3n9unJokkI6y6QqGOxfT5ea0 0UBckS69aCtzH7hA3dT77bFa2NkQf9dIjb5hT5g2hfaxgdBka35JNTSySAkyGqJBnMLB M7qbfBbxmZNB1vvQAqGbmyKhTWH+/QB07VuRWnpAJ+QJhBqGgq5M1Ggr25jrl2FhzhjT qMWguKjRVxgoJmye30FyWD6hm0rlEznUmwASqeqvnZ/mxKEL3RDdfd2QE9KQcuuhUL1N yyHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=ySBqG1B4zvvcQQ/fe2eFp1tNS620vXvYDTgjfYHiu/c=; b=VHIoTAMBKyi+Wlw6kcGNP0VHziU7NOGrVzP+CpcwDaTYcN7zGVIvz+J9S8P1wlVDhd 0RMpxTFdcbuCF0WUiwtCqYhAz8prt8ngL3TvEv6vxWF4OlXnvNw9EQJcsHwQEf4xY+aG oQax9foi7oX82dePOkdGHf4E0pxsuL/3mBueuqtYh3YpEF22QLz+ZvDowT0LAefcrGMq +2UWOXAZoXamzisRiYEJfiHbIFPK68/v5D5JufTDZ/0QtP4YOJR7UMCE+9fEMv4TUSoC jTA+2r6BEdWSkzdQg5BuG262lUAEfYre/s3J6NAPQ9kgbWzmbsmSoAujm+aTh4FCliQM PiSQ== X-Gm-Message-State: AOAM533ZpAw9IEfCpTqyH4ASq5SiZQlAtLaJBTbnIw9VFh5ryfnx4MJe 3ri7huJg7CEGV0Nko8kg7B0= X-Google-Smtp-Source: ABdhPJySD2E03PFLuNfnFpH10FdBJ16nuZCPr0wIIdhUyoFJfqYXjgvIXkGRDEwQ58DX7vEEdMp1gQ== X-Received: by 2002:a17:902:7c89:b029:da:97e0:689d with SMTP id y9-20020a1709027c89b02900da97e0689dmr16780052pll.70.1607354235646; Mon, 07 Dec 2020 07:17:15 -0800 (PST) Received: from localhost (199-83-220-90.PUBLIC.monkeybrains.net. [199.83.220.90]) by smtp.gmail.com with ESMTPSA id d4sm10669698pjz.28.2020.12.07.07.17.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 07:17:15 -0800 (PST) From: Jack Kamm To: Kyle Meyer , Ferdinand Pieper Subject: Re: [PATCH] Persistently save downloaded inline remote images In-Reply-To: <877dpu40vw.fsf@kyleam.com> References: <87blhosdw3.fsf@ims.uni-hannover.de> <877dpu40vw.fsf@kyleam.com> Date: Mon, 07 Dec 2020 07:17:14 -0800 Message-ID: <877dptd4sl.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::42a; envelope-from=jackkamm@gmail.com; helo=mail-pf1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.albinus@gmx.de, emacs-orgmode@gnu.org, kit@kychoi.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: B793294038E X-Spam-Score: -4.00 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: txJJlnMjioTU > Jack, as the author of the org-display-remote-inline-images commit, what > do you think about this patch? This patch takes the same approach as an earlier attempt by Kit in 2014 [1]. That patch was never merged; Michael objected that the approach seemed too complex, and suggested using file-local-copy and cacheing the filename instead; he also suggested implementing this cacheing functionality in Tramp instead of Org. So, when I submitted a new attempt at this, I chose to cache by simply opening the image files in Emacs instead, since the implementation is much simpler, and would hopefully sidestep the objections from the 2014 approach. While cacheing via tempfiles is more complex, it does have some benefits: it allows cacheing across Emacs sessions, and it avoids the side effect of opening the image files in Emacs. I'm agnostic whether tempfiles or Emacs buffers are ultimately better. My inclination is to be conservative and stick with the status quo unless there's a compelling reason to switch. So, I suggest Ferdinand confirm he's tested the existing "cache" option, and articulate why he found it unsuitable, before merging this. If we do proceed in this direction, I'd suggest replacing the current cache mechanism entirely -- I don't see a good reason to maintain 2 solutions to the same problem. Also, we could combine the "download" and "cache" options into a single implementation, making them synonyms for backwards compatibility. [1] https://lists.gnu.org/archive/html/emacs-orgmode/2014-11/msg00690.html [2] https://lists.gnu.org/archive/html/emacs-orgmode/2020-01/msg00177.html