emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Guilherme Passos <gpp_92@hotmail.com>,
	"emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: BUG - ox-latex - bib expansion bug and documentation error
Date: Thu, 11 Jul 2019 00:07:48 -0400	[thread overview]
Message-ID: <877e8p1aej.fsf@kyleam.com> (raw)
In-Reply-To: <FR1P15201MB22937883B348522180546116FCF00@FR1P15201MB2293.LAMP152.PROD.OUTLOOK.COM>

Hi Guilherme,

Guilherme Passos <gpp_92@hotmail.com> writes:

> In ox-latex.el, line 1189, org-latex-pdf-process uses '(%bib %b) for
> expanding the bibliography. However, this incorrectly expands as
> '(BIBFILEib BIBFILE), instead of '(BIBPROCESS BIBFILE) as intended,
> defining the process of calling the bibliography.
>
> As can be seen in line 3635, the correct command for the bibprocess is
> %B, not %bib.  The documentation is also wrong in lines 1137 and 1160
> for saying that %bib is the correct command.

I don't use ox-latex.el and may be missing something, but looking at the
code I think %bib, as described by the docstring of
org-latex-pdf-process, is intended.

When %bib was added in 74da3bc10 (ox-latex: Support arbitrary
bibtex-like program, 2015-07-08), it appears that it was working as
documented.  But with the switch to using format-spec internally in
f6187deca (ox-latex: Small refactor, 2015-09-13), the field was changed
from %bib to %bibtex.  Based on the commit message, I don't think that
was intentional.

> The only thing necessary is to replace %bib with %B in those lines.

Given the situation I described above, I think the options are

  * change %bib to %B (your suggestion) and remove the "bib" part from
    the regexp in org-latex-compile because keeping it around would be
    confusing

  * update the documentation and type in org-latex-pdf-process to use
    %bibtex

  * update the regexp in org-latex-compile to match "bib", not "bibtex"

The last one seems preferable to me, assuming the change from %bib to
%bibtex was an oversight.  What do you think?

> Should I send a patch?

Yes, please.

-- 
Kyle

      reply	other threads:[~2019-07-11  4:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-10 17:32 BUG - ox-latex - bib expansion bug and documentation error Guilherme Passos
2019-07-11  4:07 ` Kyle Meyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877e8p1aej.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=gpp_92@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).