From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sKIbNw8dml8xVgAA0tVLHw (envelope-from ) for ; Thu, 29 Oct 2020 01:38:23 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6PHKMg8dml9RWgAAB5/wlQ (envelope-from ) for ; Thu, 29 Oct 2020 01:38:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8A4009401BC for ; Thu, 29 Oct 2020 01:38:22 +0000 (UTC) Received: from localhost ([::1]:40142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXwtR-0005xl-8e for larch@yhetil.org; Wed, 28 Oct 2020 21:38:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXwsh-0005xa-7m for emacs-orgmode@gnu.org; Wed, 28 Oct 2020 21:37:35 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:51546) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXwrF-00006k-Re for emacs-orgmode@gnu.org; Wed, 28 Oct 2020 21:37:33 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 80841762A0; Wed, 28 Oct 2020 21:36:02 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=kiipBSZk7+fay/UitROxt9D0CEM=; b=vQZbBr pEKzviGmkj7DxJRIcvhFbektN/jzwzXDtNbxMFyIvLXUtzLmpk2GMdqOqq5k3GMZ UiDzyiLSKY3tX5gJcNIRzI2bxH1xBlqbk2GEPKVBhrWd5cIdpk/MCRu+c+pt9T6a ls0BtfSCi1PBG8MsqUugJ+1fNZk08dfZ0MLXs= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 44ECC7629C; Wed, 28 Oct 2020 21:36:02 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=x+tBRJevTQr8eH/OVFRDKHire0iGO41t7Gqa/20itWE=; b=0gKj7CIrsw5v80JjbaDwdOV9NECSS2TIWRESEq0Oe9EwZfbMVfTnISVJ0uqVDPUOa9kZrvVQd/Oh23of3JAQexqhgou+yO1symRj2I0Lr/V24lZFDMTghN3b+RDoaQxta/TEuMOk9K/Ms1POaDQHmsNWLcRV8/dCS5gv/MLEXpE= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id DAC1E7629A; Wed, 28 Oct 2020 21:36:00 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: ian martins Subject: Re: [PATCH] change the ob-java default back to scripting mode In-Reply-To: References: Date: Wed, 28 Oct 2020 21:35:59 -0400 Message-ID: <878sbpvmo0.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 19CE20D8-1987-11EB-B87B-74DE23BA3BAF-24757444!pb-smtp2.pobox.com Received-SPF: pass client-ip=64.147.108.71; envelope-from=kyle@kyleam.com; helo=pb-smtp2.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/28 21:36:02 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org-Mode mailing list Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=vQZbBr p; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=0gKj7CIr; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: hHzWGnuwHW7U ian martins writes: > Subject: [PATCH] ob-java.el: Change the default back to scripting mode > > * lisp/ob-java.el: Change the default to scripting mode. Add name to > authors. The changelog entry should explicitly list the variables/functions that are modified. So in this case * lisp/ob-java.el (org-babel-default-header-args:java): ... > A recent commit added functional mode and made it default, but this > would break java source blocks for anyone that relied on the old > default. This sets the default back to scripting mode. Thanks for restoring the behavior. > I missed a name when I put the authors of ob-C and ob-python as the > authors of ob-java. Added it. Please move this unrelated change to a separate commit.