From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: org-babel-insert-result doesn't comma escape properly
Date: Thu, 22 Aug 2019 19:06:43 +0200
Message-ID: <87a7c11658.fsf@nicolasgoaziou.fr>
References: <94FB08FE-1466-4B0A-B544-06A14E70114C@ucsd.edu>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:58774)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <mail@nicolasgoaziou.fr>) id 1i0qY2-00048Q-I0
 for emacs-orgmode@gnu.org; Thu, 22 Aug 2019 13:06:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mail@nicolasgoaziou.fr>) id 1i0qXy-0002T8-IA
 for emacs-orgmode@gnu.org; Thu, 22 Aug 2019 13:06:53 -0400
Received: from relay3-d.mail.gandi.net ([217.70.183.195]:60531)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
 id 1i0qXx-0002Qo-18
 for emacs-orgmode@gnu.org; Thu, 22 Aug 2019 13:06:50 -0400
In-Reply-To: <94FB08FE-1466-4B0A-B544-06A14E70114C@ucsd.edu> (Charles Berry's
 message of "Wed, 21 Aug 2019 23:28:40 +0000")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: "Berry, Charles" <ccberry@ucsd.edu>
Cc: Org Mode <emacs-orgmode@gnu.org>

Hello,

"Berry, Charles" <ccberry@ucsd.edu> writes:

> Here is an ECM:
>
> #+begin_src emacs-lisp :wrap example
> "line 1
> ,* headline 2
> ,* headline 3
> ,* headline 4
> ,* headline 5
> "
> #+end_src
>
>
> With today's master, the last `headline' is not escaped in the example
> block this produces when executed.

Indeed. Fixed.

> It seems to me that dropping the let binding for `before-finish' and placing
>
> (unless no-escape
>   (org-escape-code-in-region
>    beg end))
>
> before the insertions of 'start' and 'finish' should handle this
> properly. And trying that on the above ECM gives the right result.

But then, another regression tests fail.

> I do not see why it was needed.

I think it was to store the location of the inner part of the block.

Regards,

-- 
Nicolas Goaziou