From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id EPI0ChP6al8OHQAA0tVLHw (envelope-from ) for ; Wed, 23 Sep 2020 07:32:35 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id QAoeBhP6al9rfwAA1q6Kng (envelope-from ) for ; Wed, 23 Sep 2020 07:32:35 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A4A99940606 for ; Wed, 23 Sep 2020 07:32:34 +0000 (UTC) Received: from localhost ([::1]:36096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKzGT-0005CC-Ly for larch@yhetil.org; Wed, 23 Sep 2020 03:32:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKzFa-0005By-QR for emacs-orgmode@gnu.org; Wed, 23 Sep 2020 03:31:38 -0400 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]:37213) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kKzFZ-0006Dk-80; Wed, 23 Sep 2020 03:31:38 -0400 Received: by mail-pf1-x42a.google.com with SMTP id w7so14522150pfi.4; Wed, 23 Sep 2020 00:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=dSbf/+CojBFtTrWhisgLo66YvWxKHfXrg7Uif2bFRUA=; b=cslgju5OACmZ07ZQYluujwmWb+Pai19k+cyvopmuwPIlRv8l6bXb/SZWaJ1mhvbPWH xUK545+IMLK+BIaSW+Sqq0bxILacyh1bJAziQ3bVzNNA70tZqY9pjI6VbOUKY8QqEZrX UiZ9b8QaPbhf68GtDwCh/kCSy59mwqrYaayuPMmXz+HcZ3qXo1+Wwbrx+kNwslYF4CBQ GCM23TuKhbqFfb38hJwsmzoFVCqw9tRl7evtYIsHIRfdx2CmHMH0+JHDeHK+KC8Kt42e XeyIJDbGCSr10hLin2Jt9lS1bhwVxgI6EFgUa0m9e3Oq5YitZXdRSk0nyMoKAgWOa45Y pkzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=dSbf/+CojBFtTrWhisgLo66YvWxKHfXrg7Uif2bFRUA=; b=frpTWefHs8nk1zb+s1K2LoA/Occ3Cniu5mOmNX8CtyrROY2Ei61GtGsng9L5IWY4AF giQQD3D1TKrLDTfpghliE/KcvhaUpSHsfvS8P6ASI7bSNTS0+jZswswQ/dn3Z/lXz0Nc J686Dj+ezN+x1lzUwiCS84C3w+tQDsuXbEov8CVq5ehuaZtMswk02xVFmvp98QdeZ0yg b2rsnMnsUi34CcM0yvrpQhYeBlPFigY/4mCQJh58A7O5T7Led0lLC2wNBoqeV+Hbwziy Yw0e/FLGIPzBYlJAL7ltWjM4u1mg7mAjNKqLmt/s89c9+7Ov+JroPAkp6ILBTqo9pLRd kW6g== X-Gm-Message-State: AOAM531Tu1meRQWpJ9NYWdAA5O2Q/IfJTxL7cJ10zV6MsbGufjW0JE3d kR7I0QGxNseb3+spFcMZkeLt10Ksw7QTKT5E X-Google-Smtp-Source: ABdhPJzPz26XmK6k0d24X9sCybXz/YRm4QAPvWrjACwqbC2v3qKGKVoEEPaOFPh+tZQoXD9MKPN4mg== X-Received: by 2002:a63:1365:: with SMTP id 37mr6464119pgt.214.1600846294675; Wed, 23 Sep 2020 00:31:34 -0700 (PDT) Received: from localhost ([104.151.51.115]) by smtp.gmail.com with ESMTPSA id y4sm17716632pfr.46.2020.09.23.00.31.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2020 00:31:33 -0700 (PDT) From: Ihor Radchenko To: Bastien Subject: Re: [patch suggestion] Mitigating the poor Emacs performance on huge org files: Do not use overlays for PROPERTY and LOGBOOK drawers In-Reply-To: <87imc5c6lg.fsf@gnu.org> References: <87h7x9e5jo.fsf@localhost> <87tv0d2nk7.fsf@localhost> <87o8qkhy3g.fsf@nicolasgoaziou.fr> <87sgfqu5av.fsf@localhost> <87sgfn6qpc.fsf@nicolasgoaziou.fr> <87367d4ydc.fsf@localhost> <87r1uuotw8.fsf@nicolasgoaziou.fr> <87mu5iq618.fsf@localhost> <87ftb9pqop.fsf@nicolasgoaziou.fr> <875zc2du63.fsf@localhost> <87wo4en8qk.fsf@nicolasgoaziou.fr> <87mu31adeu.fsf@localhost> <871rkcbx40.fsf@kyleam.com> <87mu301in8.fsf@localhost> <87lfh5vvrp.fsf@localhost> <87sgbc4qpl.fsf@gmail.com> <87sgbaw58y.fsf@localhost> <87pn6ew2pv.fsf@localhost> <8736393tlw.fsf@gmail.com> <87eemtm1ic.fsf@localhost> <87imc5c6lg.fsf@gnu.org> Date: Wed, 23 Sep 2020 15:30:25 +0800 Message-ID: <87blhxlzla.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::42a; envelope-from=yantar92@gmail.com; helo=mail-pf1-x42a.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org, =?utf-8?Q?K=C3=A9vin?= Le Gouguec Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=cslgju5O; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 0.59 X-TUID: UC7AHzz3ClL1 > Can you share this gist as a patch against Org's current master? That is not possible. The underlying reason of the bug in the patch is different from master. On master, the overlays for folded drawers and headlines are merged together - when folded headline is opened by isearch, everything is revealed. The fix would involve special logic re-hiding drawers when necessary. On the org-fold feature branch, the drawers and headlines are folded independently. The reason why the bug persisted was my mistake in org-hide-drawers - I skipped drawers inside folded headlines, even when the drawers themselves were not folded. In my case the fix was trivial - I replaced condition when to skip drawer at point: [any fold is present at point] -> [drawer fold is present at point] (org-fold-get-folding-spec) -> (org-fold-get-folding-spec (org-fold-get-folding-spec-for-element 'drawer)) So, the fix is only relevant to the whole org-fold branch. Best, Ihor Bastien writes: > Hi Ihor, > > Ihor Radchenko writes: > >> Thanks for reporting! I accidentally reintroduced the bug because of >> mistake when converting org-hide-drawers to new folding library. >> (:facepalm:). >> >> Should be fixed in the gist now. > > Can you share this gist as a patch against Org's current master? > > -- > Bastien