From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mLqXBjv1cl9uLgAA0tVLHw (envelope-from ) for ; Tue, 29 Sep 2020 08:50:03 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id SHFxAjv1cl9TVQAAB5/wlQ (envelope-from ) for ; Tue, 29 Sep 2020 08:50:03 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 315A29402B3 for ; Tue, 29 Sep 2020 08:50:01 +0000 (UTC) Received: from localhost ([::1]:46366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNBKh-0003pY-P8 for larch@yhetil.org; Tue, 29 Sep 2020 04:49:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNAZW-00006B-22 for emacs-orgmode@gnu.org; Tue, 29 Sep 2020 04:01:14 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]:28913) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNAZT-0007VF-8K for emacs-orgmode@gnu.org; Tue, 29 Sep 2020 04:01:13 -0400 Date: Tue, 29 Sep 2020 08:00:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail; t=1601366466; bh=kxOxcrgBrvPQHs5oRJzEpQ2HnfUOizuw0SlhXYw4f5k=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=l61jOh0Npl7QTOOS7gvaqI1woif6rRL/kGmK+9vXmBM1Mvf26KbxZDGob71SniQu2 XEedtmuuO67MdyNYMJUEpLZCgLUQ22ZHmO/oNdZuuHzG3xgmmccWyi86YRkGomf+HE 6m5ddP75RPEsJwjroTt9Bdm949vGvS31PnIqnUPQXHqTyNDTWNrRX3GSjbfZuEj1Hq V1kfk+s9d/O+X5LExcAUl1Jg94p/390dxj8SOAJZyICrE9FYsd0kohWpLKQN/NHIEd ywVUOAPEt5Ot0mOHvDW5/IL1o9cOj2nqYyPGD9HeTeyd3izqDfIrfZOV8ecjUV0O35 /D9Sr8Jsf+JlQ== To: Protesilaos Stavrou From: Roman Rudakov Cc: emacs-orgmode@gnu.org Subject: Re: Bug: org-priority face has extra space at the end starting from version 9.4 [9.4 (9.4-elpaplus @ /home/rrudakov/.emacs.d/elpa/org-plus-contrib-20200914/)] Message-ID: <87d025ypu1.fsf@pm.me> In-Reply-To: <87o8m6aysz.fsf@protesilaos.com> References: <87r1r2kh77.fsf@pm.me> <87o8m6aysz.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.40.131; envelope-from=rrudakov@pm.me; helo=mail-40131.protonmail.ch X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/29 04:01:06 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.614, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 29 Sep 2020 04:49:19 -0400 X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Roman Rudakov Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pm.me header.s=protonmail header.b=l61jOh0N; dmarc=pass (policy=quarantine) header.from=pm.me; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.71 X-TUID: mtPX4Btc7CSu "Protesilaos Stavrou" writes: > Roman Rudakov [2020-09-15, 18:50 +0000]: > >> I use theme which draw boxes around priority cookie. Before updating to >> version 9.4 box was rendered just around square brackets, but since >> version 9.4 it has additional space at the end. >> >> I think it's related to the fact that org-priority face definition used >> to use separate regex which didn't include space, and now it uses >> variable org-priority-regexp which does include additional space >> character. >> >> [...] > > This issue is noticeable with any face properties for 'org-priority' > such as box, background, underline, overline. > > Just to add a reproducible recipe for this case. > > On 'emacs -Q' running Org 9.4: > > + C-x C-f /tmp/test.org > + Insert a heading, like: > > * TODO [#A] This is a test > > =E2=80=A6see attached screenshot with "default" state. > > * Now evaluate the following expression: > > (set-face-attribute 'org-priority nil :underline t) > > =E2=80=A6see attached screenshot with "edited" state. > > -- > Protesilaos Stavrou > protesilaos.com Hello, I think proper value for `org-priority-regex` should be ".*?\\(\\[#\\([A-Z0-9]+\\)\\]\\) ?", extra space should be moved out of the brackets, It won't break anything and face definition will be correct. Best regards.