From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Meyer Subject: Re: Status line change? Date: Thu, 22 Jun 2017 21:16:42 -0400 Message-ID: <87d19v7bb9.fsf@kyleam.com> References: <20170622233907.GA16800@volibear.adamsinfoserv.com> <87h8z77dky.fsf@kyleam.com> <20170623005342.GC16800@volibear.adamsinfoserv.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dODDO-0005tf-AQ for emacs-orgmode@gnu.org; Thu, 22 Jun 2017 21:16:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dODDJ-00067L-Mi for emacs-orgmode@gnu.org; Thu, 22 Jun 2017 21:16:50 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:55481 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dODDJ-000672-Hq for emacs-orgmode@gnu.org; Thu, 22 Jun 2017 21:16:45 -0400 In-Reply-To: <20170623005342.GC16800@volibear.adamsinfoserv.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Russell Adams , emacs-orgmode Russell Adams writes: > On Thu, Jun 22, 2017 at 08:27:41PM -0400, Kyle Meyer wrote: >> Testing with 9.0.5 and 9.0.9, I see a "TODO state changed to DONE" >> message in the echo area, which I think is what you're referring to. >> Not sure what the issue would be. You could check if you see the >> message in your *Messages* buffer. If you do, then a subsequent message >> is may be masking it. You could also debug org-todo to verify that the >> "(message "TODO state changed to %s" (org-trim next))" line is being >> executed. > > I just tested it again, and the key is if the headline is on the screen I see a status message. If the headline is off > screen there is no update on the status line. That's why it's an annoyance, I have to scroll back several screens to > confirm it changes to DONE. I see. With the headline off the screen, I can reproduce this. I've bisected it down to dd17e9d29 (org.el (org-todo): When changing from one state to the same state, throw a more accurate message, 2014-05-31). That change seems to have unintentionally reversed the visibility check, which should be -- >8 -- diff --git a/lisp/org.el b/lisp/org.el index 1e6d00973..d9b6489ff 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -12681,7 +12681,7 @@ (defun org-todo (&optional arg) (replace-match next t t) (cond ((equal this org-state) (message "TODO state was already %s" (org-trim next))) - ((pos-visible-in-window-p hl-pos) + ((not (pos-visible-in-window-p hl-pos)) (message "TODO state changed to %s" (org-trim next)))) (unless head (setq head (org-get-todo-sequence-head org-state)