From: Kyle Meyer <kyle@kyleam.com>
To: Cheong Yiu Fung <cheongyiufung@gmail.com>
Cc: Emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] ox-odt.el: quote output file name
Date: Sun, 22 Nov 2020 22:28:42 -0500 [thread overview]
Message-ID: <87eekkvjit.fsf@kyleam.com> (raw)
In-Reply-To: <f675d54f-fe76-4dd7-aac4-8908c628e85d@www.fastmail.com>
Cheong Yiu Fung writes:
> Hello,
>
> Here's a patch to quote output file name following the fashion of
> input file name as used in `org-odt-convert'. It avoids conversion
> errors in the underlying shell commands.
[...]
Thanks! Applied (2d23d55ac)...
> ---
> lisp/ox-odt.el | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/ox-odt.el b/lisp/ox-odt.el
> index 01c0e6a90..59fe369e9 100644
> --- a/lisp/ox-odt.el
> +++ b/lisp/ox-odt.el
> @@ -4240,9 +4240,9 @@ Return output file's name."
> `((?i . ,(shell-quote-argument in-file))
> (?I . ,(browse-url-file-url in-file))
> (?f . ,out-fmt)
> - (?o . ,out-file)
> + (?o . ,(shell-quote-argument out-file))
> (?O . ,(browse-url-file-url out-file))
> - (?d . , (shell-quote-argument out-dir))
> + (?d . ,(shell-quote-argument out-dir))
...dropping this unrelated space change to the out-dir entry.
next prev parent reply other threads:[~2020-11-23 3:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 9:03 [PATCH] ox-odt.el: quote output file name Cheong Yiu Fung
2020-11-23 3:28 ` Kyle Meyer [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-11-20 9:28 Cheong Yiu Fung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eekkvjit.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=cheongyiufung@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).