From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jambunathan K Subject: [BUG] Ugly checkbox on HTML export Date: Wed, 29 Jun 2011 18:28:29 +0530 Message-ID: <81mxh0bxqi.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([140.186.70.92]:36994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbuLy-0003qC-Qg for emacs-orgmode@gnu.org; Wed, 29 Jun 2011 08:58:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QbuLx-000225-EE for emacs-orgmode@gnu.org; Wed, 29 Jun 2011 08:58:50 -0400 Received: from mail-pw0-f41.google.com ([209.85.160.41]:41730) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbuLx-000220-0t for emacs-orgmode@gnu.org; Wed, 29 Jun 2011 08:58:49 -0400 Received: by pwi12 with SMTP id 12so1039811pwi.0 for ; Wed, 29 Jun 2011 05:58:47 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain A test file and the html output are attached. The "ugly" checkbox is ugly only because it is unlike anyother checkboxes. git commit at 66537. Behavious confirmed with emacs -Q. --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=ugly-checkbox.org Content-Description: ugly-checkbox.org * Fun with Square Brackets Checkbox at item 13 is "ugly" in the exported HTML. 1. One 2. Two 3. Three[fn:1][fn:2] 10. [@10] Ten 11. Eleven 6. [@6] Six 7. [ ] Seven with Checkbox 8. [ ] Eight with Checkbox 13. [@13] [ ] Restart at thirteen [2/3] - [X] Peter - [X] Sarah - [-] Sam[fn:3][fn:4][1/3] - [ ] Alpha - [ ] Beta - [X] Gamma 14. Too much fun is injurious to health * Footnotes [fn:1] Footnote-1 [fn:2] Footnote-2 [fn:3] Footnote-3 [fn:4] Footnote-4 --=-=-= Content-Type: text/html Content-Disposition: attachment; filename=ugly-checkbox.html Content-Description: ugly-checkbox.html ugly-checkbox

ugly-checkbox

Table of Contents

1 Fun with Square Brackets

Checkbox at item 13 is "ugly" in the exported HTML.

  1. One
  2. Two
  3. Three1, 2
  4. Ten
  5. Eleven
  6. Six
  7. [ ] Seven with Checkbox
  8. [ ] Eight with Checkbox
  9. [ ] Restart at thirteen [2/3]
    • [X] Peter
    • [X] Sarah
    • [-] Sam3, 4[1/3]
      • [ ] Alpha
      • [ ] Beta
      • [X] Gamma
  10. Too much fun is injurious to health

Footnotes:

1 Footnote-1

2 Footnote-2

3 Footnote-3

4 Footnote-4

Date: 2011-06-29 18:15:05

Author:

Org version 7.5 with Emacs version 24

Validate XHTML 1.0
--=-=-= Content-Type: text/plain -- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manuel Giraud Subject: Re: [BUG] Ugly checkbox on HTML export Date: Wed, 29 Jun 2011 17:02:43 +0200 Message-ID: <87oc1gbrzg.fsf@univ-nantes.fr> References: <81mxh0bxqi.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([140.186.70.92]:39907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbwHv-0004RK-PC for emacs-orgmode@gnu.org; Wed, 29 Jun 2011 11:02:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QbwHt-0006Jf-Kb for emacs-orgmode@gnu.org; Wed, 29 Jun 2011 11:02:47 -0400 Received: from smtp-tls1.univ-nantes.fr ([193.52.101.145]:43843 helo=smtp-tls.univ-nantes.fr) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbwHt-0006JT-80 for emacs-orgmode@gnu.org; Wed, 29 Jun 2011 11:02:45 -0400 In-Reply-To: <81mxh0bxqi.fsf@gmail.com> (Jambunathan K.'s message of "Wed, 29 Jun 2011 18:28:29 +0530") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Jambunathan K Cc: emacs-orgmode@gnu.org --=-=-= Jambunathan K writes: > A test file and the html output are attached. The "ugly" checkbox is > ugly only because it is unlike anyother checkboxes. This patch should do. Hope it doesn't break any other case. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0002-org-html.el-org-html-export-list-line-correct-the-ug.patch >From a316c18009b878c3edd2ef241fd42ba25b91246a Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Wed, 29 Jun 2011 16:57:03 +0200 Subject: [PATCH 2/2] * org-html.el (org-html-export-list-line): correct the ugly checkbox --- lisp/org-html.el | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lisp/org-html.el b/lisp/org-html.el index 174ee4b..814b772 100644 --- a/lisp/org-html.el +++ b/lisp/org-html.el @@ -2532,7 +2532,7 @@ the alist of previous items." (string-match (concat "[ \t]*\\(\\S-+[ \t]*\\)" "\\(?:\\[@\\(?:start:\\)?\\([0-9]+\\|[A-Za-z]\\)\\]\\)?" - "\\(?:\\(\\[[ X-]\\]\\)[ \t]+\\)?" + "[ \t]*\\(?:\\(\\[[ X-]\\]\\)[ \t]+\\)?" "\\(?:\\(.*\\)[ \t]+::\\(?:[ \t]+\\|$\\)\\)?" "\\(.*\\)") line) (let* ((checkbox (match-string 3 line)) -- 1.7.5 --=-=-= -- Manuel Giraud --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manuel Giraud Subject: Re: [BUG] Ugly checkbox on HTML export Date: Wed, 29 Jun 2011 17:14:58 +0200 Message-ID: <87ei2cbrf1.fsf@univ-nantes.fr> References: <81mxh0bxqi.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([140.186.70.92]:58220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbwTm-00088r-5p for emacs-orgmode@gnu.org; Wed, 29 Jun 2011 11:15:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QbwTk-0000pr-49 for emacs-orgmode@gnu.org; Wed, 29 Jun 2011 11:15:01 -0400 Received: from smtp-tls1.univ-nantes.fr ([193.52.101.145]:34549 helo=smtp-tls.univ-nantes.fr) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbwTj-0000pd-PH for emacs-orgmode@gnu.org; Wed, 29 Jun 2011 11:14:59 -0400 In-Reply-To: <81mxh0bxqi.fsf@gmail.com> (Jambunathan K.'s message of "Wed, 29 Jun 2011 18:28:29 +0530") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Jambunathan K Cc: emacs-orgmode@gnu.org --=-=-= Oops, the previous patch was applied on top on another one I have here. This one's better. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-org-html.el-org-html-export-list-line-correct-the-ug.patch >From d9533465909a822275c01450cb00afa96ddcf1b6 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Wed, 29 Jun 2011 17:11:16 +0200 Subject: [PATCH] * org-html.el (org-html-export-list-line): correct the ugly checkbox --- lisp/org-html.el | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lisp/org-html.el b/lisp/org-html.el index a343647..db8b42b 100644 --- a/lisp/org-html.el +++ b/lisp/org-html.el @@ -2532,7 +2532,7 @@ the alist of previous items." (string-match (concat "[ \t]*\\(\\S-+[ \t]*\\)" "\\(?:\\[@\\(?:start:\\)?\\([0-9]+\\|[A-Za-z]\\)\\]\\)?" - "\\(?:\\(\\[[ X-]\\]\\)[ \t]+\\)?" + "[ \t]*\\(?:\\(\\[[ X-]\\]\\)[ \t]+\\)?" "\\(?:\\(.*\\)[ \t]+::\\(?:[ \t]+\\|$\\)\\)?" "\\(.*\\)") line) (let* ((checkbox (match-string 3 line)) -- 1.7.5 --=-=-= -- Manuel Giraud --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [BUG] Ugly checkbox on HTML export Date: Wed, 29 Jun 2011 19:59:02 +0200 Message-ID: <87liwkbjtl.fsf@gmail.com> References: <81mxh0bxqi.fsf@gmail.com> <87oc1gbrzg.fsf@univ-nantes.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:35759) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qbz2c-0003DB-Ul for emacs-orgmode@gnu.org; Wed, 29 Jun 2011 13:59:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qbz2a-0007KC-7Z for emacs-orgmode@gnu.org; Wed, 29 Jun 2011 13:59:10 -0400 Received: from mail-ww0-f49.google.com ([74.125.82.49]:49557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qbz2Z-0007JM-B4 for emacs-orgmode@gnu.org; Wed, 29 Jun 2011 13:59:07 -0400 Received: by wwf22 with SMTP id 22so1213532wwf.30 for ; Wed, 29 Jun 2011 10:59:06 -0700 (PDT) In-Reply-To: <87oc1gbrzg.fsf@univ-nantes.fr> (Manuel Giraud's message of "Wed, 29 Jun 2011 17:02:43 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Manuel Giraud Cc: emacs-orgmode@gnu.org, Jambunathan K Hello, Manuel Giraud writes: > Jambunathan K writes: > >> A test file and the html output are attached. The "ugly" checkbox is >> ugly only because it is unlike anyother checkboxes. > > This patch should do. Hope it doesn't break any other case. The "problem" is deeper than that. At the moment [@6] [ ] isn't recognized as a valid check-box, while [@6][ ] is. Proof: try to C-c C-c the ugly checkbox. Anyhow, for now, when there is both a counter and a checkbox in the item, you have to stick them. It will then export fine. Regards, -- Nicolas Goaziou From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [BUG] Ugly checkbox on HTML export Date: Thu, 30 Jun 2011 23:02:35 +0200 Message-ID: <874o37av84.fsf@gmail.com> References: <81mxh0bxqi.fsf@gmail.com> <87ei2cbrf1.fsf@univ-nantes.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:51534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcONr-0007UB-S9 for emacs-orgmode@gnu.org; Thu, 30 Jun 2011 17:02:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QcONq-0003VM-9O for emacs-orgmode@gnu.org; Thu, 30 Jun 2011 17:02:47 -0400 Received: from mail-ww0-f49.google.com ([74.125.82.49]:51953) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcONp-0003V9-PZ for emacs-orgmode@gnu.org; Thu, 30 Jun 2011 17:02:46 -0400 Received: by wwf22 with SMTP id 22so2151611wwf.30 for ; Thu, 30 Jun 2011 14:02:44 -0700 (PDT) In-Reply-To: <87ei2cbrf1.fsf@univ-nantes.fr> (Manuel Giraud's message of "Wed, 29 Jun 2011 17:14:58 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Manuel Giraud Cc: emacs-orgmode@gnu.org, Jambunathan K Hello, Manuel Giraud writes: > Oops, the previous patch was applied on top on another one I have > here. This one's better. I've pushed a fix for that problem in git master. Spaces between counters and check-boxes should now be supported. Regards, -- Nicolas Goaziou From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [BUG] Ugly checkbox on HTML export Date: Fri, 01 Jul 2011 17:17:43 +0200 Message-ID: <87ei2a6ne0.fsf@gnu.org> References: <81mxh0bxqi.fsf@gmail.com> <87ei2cbrf1.fsf@univ-nantes.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:36817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcfT9-0005J7-1J for emacs-orgmode@gnu.org; Fri, 01 Jul 2011 11:17:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QcfT3-0005ck-Jo for emacs-orgmode@gnu.org; Fri, 01 Jul 2011 11:17:22 -0400 Received: from mail-ww0-f49.google.com ([74.125.82.49]:51987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcfT2-0005bO-Vy for emacs-orgmode@gnu.org; Fri, 01 Jul 2011 11:17:17 -0400 Received: by wwf22 with SMTP id 22so2685405wwf.30 for ; Fri, 01 Jul 2011 08:17:15 -0700 (PDT) In-Reply-To: <87ei2cbrf1.fsf@univ-nantes.fr> (Manuel Giraud's message of "Wed, 29 Jun 2011 17:14:58 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Manuel Giraud Cc: Nicolas , emacs-orgmode@gnu.org, Jambunathan K Hi Manuel, Manuel Giraud writes: > Oops, the previous patch was applied on top on another one I have > here. This one's better. I let Nicolas decide on this one. -- Bastien From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manuel Giraud Subject: Re: [BUG] Ugly checkbox on HTML export Date: Fri, 01 Jul 2011 17:49:11 +0200 Message-ID: <871uyaxaq0.fsf@univ-nantes.fr> References: <81mxh0bxqi.fsf@gmail.com> <87ei2cbrf1.fsf@univ-nantes.fr> <87ei2a6ne0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([140.186.70.92]:58932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qcfy0-0005Co-T9 for emacs-orgmode@gnu.org; Fri, 01 Jul 2011 11:49:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qcfxy-0005Qp-Fh for emacs-orgmode@gnu.org; Fri, 01 Jul 2011 11:49:16 -0400 Received: from smtp-tls1.univ-nantes.fr ([193.52.101.145]:40215 helo=smtp-tls.univ-nantes.fr) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qcfxy-0005Pl-5o for emacs-orgmode@gnu.org; Fri, 01 Jul 2011 11:49:14 -0400 In-Reply-To: <87ei2a6ne0.fsf@gnu.org> (Bastien's message of "Fri, 01 Jul 2011 17:17:43 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: Nicolas , emacs-orgmode@gnu.org, Jambunathan K Bastien writes: > Hi Manuel, > > Manuel Giraud writes: > >> Oops, the previous patch was applied on top on another one I have >> here. This one's better. > > I let Nicolas decide on this one. Nicolas' patch is already applied and far more complete than mine. So I guess it's decided ;-) -- Manuel Giraud From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [BUG] Ugly checkbox on HTML export Date: Fri, 01 Jul 2011 17:56:29 +0200 Message-ID: <87pqlu3sgi.fsf@gnu.org> References: <81mxh0bxqi.fsf@gmail.com> <87ei2cbrf1.fsf@univ-nantes.fr> <87ei2a6ne0.fsf@gnu.org> <871uyaxaq0.fsf@univ-nantes.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:55678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qcg4a-00073Q-86 for emacs-orgmode@gnu.org; Fri, 01 Jul 2011 11:56:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qcg4Y-0006jN-Kv for emacs-orgmode@gnu.org; Fri, 01 Jul 2011 11:56:04 -0400 Received: from mail-ww0-f41.google.com ([74.125.82.41]:37768) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qcg4Y-0006iE-3v for emacs-orgmode@gnu.org; Fri, 01 Jul 2011 11:56:02 -0400 Received: by wwi14 with SMTP id 14so38070wwi.0 for ; Fri, 01 Jul 2011 08:56:00 -0700 (PDT) In-Reply-To: <871uyaxaq0.fsf@univ-nantes.fr> (Manuel Giraud's message of "Fri, 01 Jul 2011 17:49:11 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Manuel Giraud Cc: Nicolas , emacs-orgmode@gnu.org, Jambunathan K Manuel Giraud writes: > Nicolas' patch is already applied and far more complete than mine. So > I guess it's decided ;-) Great -- thanks for the update! -- Bastien