From: Protesilaos Stavrou <info@protesilaos.com>
To: Kyle Meyer <kyle@kyleam.com>
Cc: Roman Rudakov <rrudakov@pm.me>,
Protesilaos Stavrou <info@protesilaos.com>,
emacs-orgmode@gnu.org, Ilja Kocken <iljakocken@gmail.com>
Subject: Re: Bug: org-priority face has extra space at the end starting from version 9.4 [9.4 (9.4-elpaplus @ /home/rrudakov/.emacs.d/elpa/org-plus-contrib-20200914/)]
Date: Mon, 12 Oct 2020 09:48:23 +0300 [thread overview]
Message-ID: <87ft6klz2g.fsf@protesilaos.com> (raw)
In-Reply-To: <87k0vx8dtz.fsf@kyleam.com> (Kyle Meyer's message of "Sun, 11 Oct 2020 02:40:56 -0400")
On 2020-10-11, 02:40 -0400, Kyle Meyer <kyle@kyleam.com> wrote:
> I'm wary of changing the regexp. Although the docstring does suggest
> the space shouldn't be a part of the first group, the group has included
> the space since org-priority-regex was introduced way back in 2008. And
> making the suggested change results in a failing test
> (test-org/entry-put). So at this point, I'd lean towards adjusting the
> docstring.
>
> I've applied a different fix for the regression (b1de0c8e4).
Thank you Kyle! I can confirm that the issue is no longer present on my
end.
--
Protesilaos Stavrou
protesilaos.com
prev parent reply other threads:[~2020-10-12 6:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 18:50 Bug: org-priority face has extra space at the end starting from version 9.4 [9.4 (9.4-elpaplus @ /home/rrudakov/.emacs.d/elpa/org-plus-contrib-20200914/)] Roman Rudakov
2020-09-16 8:52 ` Protesilaos Stavrou
2020-09-29 8:00 ` Roman Rudakov
2020-10-04 14:36 ` Protesilaos Stavrou
2020-10-11 6:40 ` Kyle Meyer
2020-10-12 6:48 ` Protesilaos Stavrou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ft6klz2g.fsf@protesilaos.com \
--to=info@protesilaos.com \
--cc=emacs-orgmode@gnu.org \
--cc=iljakocken@gmail.com \
--cc=kyle@kyleam.com \
--cc=rrudakov@pm.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).