emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Gustavo Barros <gusbrs.2016@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: org-refile-get-target offers default candidate in duplicity [9.2.6 (9.2.6-4-ge30905-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20191007/)]
Date: Fri, 14 Feb 2020 11:02:51 +0100	[thread overview]
Message-ID: <87h7zttrjo.fsf@bzg.fr> (raw)
In-Reply-To: 877e0qw14d.fsf@gmail.com

Hi Gustavo,

Gustavo Barros <gusbrs.2016@gmail.com> writes:

> I've tested it again, and I believe it is working as intended.

Thanks for confirming.

> I observe, however, a difference of behavior between
> "completing-read-default" and "ivy-completing-read" in the workings of 
> "org-refile-get-location". Namely, with "completing-read-default" the
> chosen target is stored in "org-refile-history" with a trailing slash 
> (the "extra" part), while with "ivy-completing-read" it is stored
> without the trailing slash.
>
> I have no idea why this is so and also don't know if this stems from
> Org's end. As far as I can tell, functionality of the feature with 
> respect to this bug report is working as intended: no duplicate
> candidates, and history is honored. But the difference surprised me
> and if you think it might be important, I can provide an ECM for it.
> Otherwise, I think this can well closed as fixed.

I've revisited org-refile-get-location given your new information on
ivy-completing-read but I'm not able to see something wrong in the
current implementation of org-refile-get-location.  At the same time,
I don't see why ivy-completing-read would handle arguments differently
than completing-read-default, so _perhaps_ org-refile-get-location
still does something wrong.

If you - or other ivy users - have time to investigate and report,
please do so.

Thanks,

-- 
 Bastien

  parent reply	other threads:[~2020-02-14 10:02 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 18:34 Bug: org-refile-get-target offers default candidate in duplicity [9.2.6 (9.2.6-4-ge30905-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20191007/)] Gustavo Barros
2020-02-12 23:35 ` Bastien
2020-02-13  1:51   ` Gustavo Barros
2020-02-13  7:45     ` Bastien
2020-02-13 19:44       ` Samuel Wales
2020-02-14 10:02         ` Bastien
2020-02-17  0:06           ` Samuel Wales
2020-02-17  0:14             ` Bastien
2020-02-17  0:17               ` Samuel Wales
2020-02-17  0:25                 ` Samuel Wales
2020-02-17  0:38                   ` Bastien
2020-02-17  1:58                     ` Samuel Wales
2020-02-17 22:55                       ` Bastien
2020-02-17  0:15             ` Samuel Wales
2020-02-13 22:53       ` Gustavo Barros
2020-02-13 23:13         ` Samuel Wales
2020-02-14 10:02         ` Bastien [this message]
2020-02-14 13:41           ` Gustavo Barros
2020-02-14 15:29             ` Bastien
2020-02-14 16:37               ` Gustavo Barros
2020-02-14 15:33           ` Gustavo Barros
2020-02-16 23:22             ` Bastien
2020-02-17  0:45               ` Gustavo Barros
2020-02-17 17:45                 ` Bastien
2020-02-13  2:06   ` Gustavo Barros
2020-02-13  7:19     ` Bastien
2020-02-13 20:51       ` Gustavo Barros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7zttrjo.fsf@bzg.fr \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=gusbrs.2016@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).