From: Kyle Meyer <kyle@kyleam.com> To: John Kitchin <jkitchin@andrew.cmu.edu> Cc: org-mode-email <emacs-orgmode@gnu.org> Subject: [PATCH] ol: Avoid initial input when completing function for storing link Date: Sat, 02 Jan 2021 22:13:58 GMT Message-ID: <87im8fdm1n.fsf@kyleam.com> (raw) In-Reply-To: <CAJ51ETqO9A8mE0W3pgU2cFzaZsESdYXAV0X-8veY+_V9AwPHdQ@mail.gmail.com> John Kitchin writes: > Recently I have had an issue where multiple functions may store a link, > e.g. to a bibtex entry. > > In this case, org-mode seems to prompt me to ask which function to store > the link with, with an initial input of the first function, which masks all > the options that are available. This happens inside org-store-link in ol.el > at line 1495 for me. in > > (apply #'org-link-store-props > (cdr (assoc-string > (completing-read > "Which function for creating the link? " > (mapcar #'car results-alist) > nil t (symbol-name name)) > results-alist))) > > because of the (symbol-name name). > > Is there an easy way to avoid this, or to modify the order of the functions > used? I want to see all the options for storing, or better, to just store > them all and let me choose later when I use org-insert-link. The "or better" sounds reasonable. Perhaps someone will attempt that, but in the meantime I think just avoiding the discouraged/mostly deprecated INITIAL-INPUT argument would be a good improvement. -- >8 -- Subject: [PATCH] ol: Avoid initial input when completing function for storing link * lisp/ol.el (org-store-link): Use completing-read's DEF argument rather than INITIAL-INPUT, which is discouraged (see Elisp manual) and may hide the other choices depending on the completion framework. Reported-by: John Kitchin <jkitchin@andrew.cmu.edu> Ref: https://orgmode.org/list/CAJ51ETqO9A8mE0W3pgU2cFzaZsESdYXAV0X-8veY+_V9AwPHdQ@mail.gmail.com --- lisp/ol.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lisp/ol.el b/lisp/ol.el index 5ba813142..cf105786f 100644 --- a/lisp/ol.el +++ b/lisp/ol.el @@ -1496,9 +1496,9 @@ (defun org-store-link (arg &optional interactive?) (apply #'org-link-store-props (cdr (assoc-string (completing-read - "Which function for creating the link? " - (mapcar #'car results-alist) - nil t (symbol-name name)) + (format "Store link with (default %s): " name) + (mapcar #'car results-alist) + nil t nil nil (symbol-name name)) results-alist))) t)))) (setq link (plist-get org-store-link-plist :link)) base-commit: 291993888d7b6776d42a86facd26c8bc0f72e475 -- 2.29.2
next prev parent reply other threads:[~2021-01-02 22:14 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-02 13:49 what do do when multiple functions store a link John Kitchin 2021-01-02 14:37 ` Daniele Nicolodi 2021-01-02 14:55 ` John Kitchin 2021-01-02 22:13 ` Kyle Meyer [this message] 2021-01-05 5:16 ` [PATCH] ol: Avoid initial input when completing function for storing link Kyle Meyer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://orgmode.org * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87im8fdm1n.fsf@kyleam.com \ --to=kyle@kyleam.com \ --cc=emacs-orgmode@gnu.org \ --cc=jkitchin@andrew.cmu.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Org-mode mailing list This inbox may be cloned and mirrored by anyone: git clone --mirror https://orgmode.org/list/0 list/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 list list/ https://orgmode.org/list \ emacs-orgmode@gnu.org public-inbox-index list Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.yhetil.org/yhetil.emacs.orgmode nntp://news.gmane.io/gmane.emacs.orgmode AGPL code for this site: git clone https://public-inbox.org/public-inbox.git