Re: [PATCH] org-plot abstractions and extension

[Kyle Meyer <kyle@kyleam.com>]

Bastien writes:

> Hi Timothy,
>
> TEC <tecosaur@gmail.com> writes:
>
>> I'll attach all the patches to this email, so there's no ambiguity.
>> (crosses fingers for attachments working as expected)
>
> Applied, with minor modifications of the changelog entries:[...]

This series introduced some compiler warnings.

  $ make compile
  [...]
  In org--plot/values-stats:
  org-plot.el:199:39:Warning: ‘log10’ is an obsolete function (as of 24.4); use
      ‘log’ instead.
  
  In org--plot/nice-frequency-pick:
  org-plot.el:229:39:Warning: ‘1’ is a malformed function
  org-plot.el:229:39:Warning: ‘2’ is a malformed function
  org-plot.el:239:32:Warning: ‘t’ called as a function
  org-plot.el:525:1:Warning: Unused lexical variable ‘col-labels’
  org-plot.el:525:1:Warning: Unused lexical variable ‘deps’
  org-plot.el:525:1:Warning: Unused lexical variable ‘text-ind’
  org-plot.el:525:1:Warning: Unused lexical variable ‘ind’
  org-plot.el:525:1:Warning: Unused lexical variable ‘map’
  
  In org-plot/gnuplot:
  org-plot.el:653:56:Warning: reference to free variable ‘type-name’
  
  In end of data:
  org-plot.el:706:1:Warning: the following functions are not known to be
      defined: case, t, s-join

Most of these are minor (case -> cl-case, dropping unused bindings,
...).  The s-join one is the most important because s.el is not a
dependency.

Timothy, could you please submit a follow-up patch to address these?