From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id INBmHLujbGBQHAAAgWs5BA (envelope-from ) for ; Tue, 06 Apr 2021 20:08:59 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id iPI8FrujbGCRagAAbx9fmQ (envelope-from ) for ; Tue, 06 Apr 2021 18:08:59 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2F6FF237FA for ; Tue, 6 Apr 2021 20:08:59 +0200 (CEST) Received: from localhost ([::1]:37152 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTq8H-00065n-IJ for larch@yhetil.org; Tue, 06 Apr 2021 14:08:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTq7g-000652-LR for emacs-orgmode@gnu.org; Tue, 06 Apr 2021 14:08:21 -0400 Received: from mout01.posteo.de ([185.67.36.65]:54177) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTq7b-0004C6-PW for emacs-orgmode@gnu.org; Tue, 06 Apr 2021 14:08:20 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 5307716005C for ; Tue, 6 Apr 2021 20:08:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1617732492; bh=leILZI9aKBUUdQcvxeMY/E2+m/fL31s9FsyUy0h5wEU=; h=From:To:Cc:Subject:Date:From; b=KkZtqI6Kl7/V+hVN9qHpxO/q/LoTBKcijj3ykINKIGPKIWBhgdDkJXMNx57zVgpY5 l0eiBQWKBrr+a22LrjTd6JNUcDjZ0M+0PZbIet/qAW/B4AOsMuchvqaiHoGyg579++ Opl8CWfo9tMWVKQx2kc/rDsSTj7mZTzhhQFtY/0a2clwEnKFfb0uOvHpf0x+A6IQ/N z/0ORym7mMWLSP5BYfqu/aRD2w6g1TzYUvWOAQJdPKOXKr3CDxGrn8Z2g+WljDuWnl T6zgkXuJDjy3pvb2Pr0ksTow0/v5Fe6Ts/1tN4RhzZVBJTMH+0TjB1823B14iA0yuG 1YkwEK2TyWJ7Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FFFrC40Ssz6tm6; Tue, 6 Apr 2021 20:08:11 +0200 (CEST) From: Ingo Lohmar To: Kyle Meyer Subject: Re: Bug: org-link-descriptive needs to be buffer-local [9.4.4 (release_9.4.4 @ /usr/local/share/emacs/28.0.50/lisp/org/)] In-Reply-To: <87zgycb0la.fsf@kyleam.com> References: <87pmzdhl4b.fsf@kenko.localhost.com> <87zgycb0la.fsf@kyleam.com> Date: Tue, 06 Apr 2021 20:08:11 +0200 Message-ID: <87lf9ve16c.fsf@kenko.localhost.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=ingo.lohmar@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org, Gustavo Barros Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 2F6FF237FA X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: zZSOlYuUPonA On Mon, Apr 05 2021 22:36 (-0400), Kyle Meyer wrote: >> I suggest a simple fix that I just tested: make `org-link-descriptive' >> automatically buffer-local, by adding ":local t" to the defcustom. > > Hmm, I think a problem with `:local t' (or, equivalently, > make-variable-buffer-local for backward compatibility reasons) is that > then you'd interfere with user customization that directly sets this > after ol.el is loaded. You could also still get into a mismatched state > like you described above if you load an Org buffer, set the value > through the customization interface, and then call > org-toggle-link-display in that buffer. > > Instead I've updated the body of `org-mode' to make org-link-descriptive > buffer-local (702e782cb). I am not sure that I understand the problem you're describing.. Maybe it's because I don't use the customize interface myself, but I think any such customization would only set the default value, wouldn't it? But in any case, I am (of course) perfectly fine with your fix, thanks a lot for the quick response!