Org-mode mailing list
 help / color / mirror / Atom feed
From: John Herrlin <>
To: ian martins <>
Cc: org-mode-email <>
Subject: Re: [PATCH] ob-java: Allow import to end with asterisk
Date: Wed, 27 Jan 2021 08:24:52 +0100
Message-ID: <> (raw)
In-Reply-To: <>

Thank you for the guidence! I will try to figure it out and sending a
updated patch soon.

ian martins <> writes:

>> I found this case:
>> And it seems to me that the import regex dont see the asterisk.
>> I attached a possible patch.
> Thanks again, John.  You're right the regex is missing the asterisk
> include. Thanks for the patch fixing. This works but it will add
> redundant includes if the source block includes something that is also
> in the list of classes to automatically include.
> for example, this:
>     #+begin_src java :results value
>       import java.util.*;
>       return "test";
>     #+end_src
> will end up pulling in
>     import java.util.List;
>     import java.util.*;
> It wouldn't hurt anything, but could probably be prevented by changing
> the regexp in =org-babel-java--import-maybe= to look for asterisk as
> well as =class=.  Do you feel like updating the patch?
> [1]

  reply	other threads:[~2021-01-27  7:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26  7:53 John Herrlin
2021-01-27  3:21 ` ian martins
2021-01-27  7:24   ` John Herrlin [this message]
2021-01-28 20:03   ` John Herrlin
2021-01-30 10:50     ` ian martins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Org-mode mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror list/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 list list/ \
	public-inbox-index list

Example config snippet for mirrors.
Newsgroups are available over NNTP:

AGPL code for this site: git clone