From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH v2] ob-vala.el: Add Vala support to Babel
Date: Tue, 01 Aug 2017 23:59:57 +0200
Message-ID: <87mv7jq78i.fsf@nicolasgoaziou.fr>
References: <87379no75t.fsf@nicolasgoaziou.fr>
	<20170801212016.7264C2DB@fluttershy.mitch.h.shuttle.de>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42522)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dcfCr-0005XE-Ko
	for emacs-orgmode@gnu.org; Tue, 01 Aug 2017 18:00:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dcfCq-0004BC-TT
	for emacs-orgmode@gnu.org; Tue, 01 Aug 2017 18:00:01 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:46063)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1dcfCq-00048z-Mp
	for emacs-orgmode@gnu.org; Tue, 01 Aug 2017 18:00:00 -0400
In-Reply-To: <20170801212016.7264C2DB@fluttershy.mitch.h.shuttle.de>
	(Christian Garbs's message of "Tue, 1 Aug 2017 00:04:34 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Christian Garbs <mitch@cgarbs.de>
Cc: emacs-orgmode@gnu.org

Hello,

Christian Garbs <mitch@cgarbs.de> writes:

> * ob-vala.el: Add support for the Vala language to Babel.
> ---
>  lisp/ob-vala.el | 122 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 122 insertions(+)
>  create mode 100644 lisp/ob-vala.el
>
> diff --git a/lisp/ob-vala.el b/lisp/ob-vala.el
> new file mode 100644
> index 0000000..0375265
> --- /dev/null
> +++ b/lisp/ob-vala.el
> @@ -0,0 +1,122 @@
> +;;; ob-vala.el --- org-babel functions for Vala evaluation

Babel functions for Vala evaluation

Also, could you use lexical binding, i.e., add "-*- lexical-binding:
t; -*-" on the first line of the file and check byte-compilation doesn't
complain.

> +(defcustom org-babel-vala-compiler "valac"
> +  "Command used to compile a C source code file into an executable.
> +May be either a command in the path, like `valac'

like \"valac\"

> +or an absolute path name, like `/usr/local/bin/valac'.

an absolute file name, like \"/usr/local/bin/valac\".

> +Parameters may be used like this: `valac -v'"

like this: \"valac -c\""

> +  :group 'org-babel
> +  :version "24.3"
> +  :type 'string)

Some keywords are missing:

  :version "26.1"
  :package-version '(Org . "9.1")

Barring the suggestions above, your patch looks good. I think we can
apply it as soon as the FSF process is complete.

Thank you!

Regards,

-- 
Nicolas Goaziou