From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wGoGEO5UvF/gGAAA0tVLHw (envelope-from ) for ; Tue, 24 Nov 2020 00:33:50 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id sMrJC+5UvF+UZAAAbx9fmQ (envelope-from ) for ; Tue, 24 Nov 2020 00:33:50 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A99349404FE for ; Tue, 24 Nov 2020 00:33:49 +0000 (UTC) Received: from localhost ([::1]:42596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khMHC-0006Xd-N6 for larch@yhetil.org; Mon, 23 Nov 2020 19:33:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khMFv-0006Wz-3s for emacs-orgmode@gnu.org; Mon, 23 Nov 2020 19:32:28 -0500 Received: from mail-qt1-x834.google.com ([2607:f8b0:4864:20::834]:46143) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khMFr-0003bB-Be for emacs-orgmode@gnu.org; Mon, 23 Nov 2020 19:32:26 -0500 Received: by mail-qt1-x834.google.com with SMTP id f15so11412916qto.13 for ; Mon, 23 Nov 2020 16:32:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:user-agent:from:to:subject:message-id:date:mime-version; bh=itH4Zjc9AQipkBRYHYxQM4eo9B6faqwQmZexhzx7n0I=; b=WnEb3JjZf/2ZjyBy4BBhhtJgMlfWKCLwWh/OZ4La+HjTfxiOWHCaLojgYrIxWFCkO8 bIrH57GGZ10pvHzF0zYI1gMXdU3yyG2/tQ2h1vc83NFK1a+0P0vx78IsZChzh7oX+yTS sCUqgWc4MyYKNc5miyDO/9JLld2fsqRdTmGpHLDhxxTcbWr8h6HRgn+0rxm+c0aUUw4R Gm4cTtMJ9kqXS+LphFkOuKA8kb9g9znP7BKp6ork8UEPOHbVPZIl6YqcnieJCNO6Dv6P fV9web61pHNDWbgvqmZnFd2ascj1sdkz6A/dUGwvD+R9iapQiqypxPb6Ta0XYQf6Br2w bfmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:user-agent:from:to:subject:message-id :date:mime-version; bh=itH4Zjc9AQipkBRYHYxQM4eo9B6faqwQmZexhzx7n0I=; b=mTYKfpa7gtPzdDfeqAI5tat4GqUSAbRT1Z4J+uKrE2PKQYstR+mm9dkFDnra4b7kBe idbDmORL2lch0gbmlu+i4Astae2zGEkMpJNzfvAxPInNtI7cXQF9yqfmFzzIigpXejL+ M4qkC6QrcpiBSoDWyFY2QMDJvt8xD6fK2OoyOzBs0o46nBVHA0l3DTL0id8BC7NxIEIZ +SWiQO+Oh+4TXz7FGnoHXrPfvG4CMiRgSVxkHAY6+L3xOPpTy32U8bG86hMrzFB5yvP0 sITN99nO8c55qCims9GVn0xyT3HMNcmdek6TUGmZqZor41iqh8VUIgBNNP7LHumQWOC5 twdQ== X-Gm-Message-State: AOAM533D3ic80wLsPDSIaXSzrzCmqXln+fEwSpIq8Q+vMgsT4xbTqy3/ TaIl0Z08L+b5Qd7AMxJBhpImGcKJmCtyXg== X-Google-Smtp-Source: ABdhPJxKAhd7mmgyuD5m7knt5A00/FFVcd0ZFmS09PekarX//Q1PCipZiYJAo2GYIx1t5UHR31o5zw== X-Received: by 2002:ac8:4685:: with SMTP id g5mr1972492qto.173.1606177940960; Mon, 23 Nov 2020 16:32:20 -0800 (PST) Received: from gusbrs-laptop ([190.106.134.90]) by smtp.gmail.com with ESMTPSA id q123sm10904721qke.28.2020.11.23.16.32.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Nov 2020 16:32:20 -0800 (PST) User-agent: mu4e 1.4.13; emacs 27.1 From: Gustavo Barros To: emacs-orgmode@gnu.org Subject: Bug: org-toggle-link-display and org-hide-emphasis-markers [9.4 (9.4-44-g5272d9-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20201123/)] Message-ID: <87o8jnzjao.fsf@gmail.com> Date: Mon, 23 Nov 2020 21:32:15 -0300 MIME-Version: 1.0 Content-Type: text/plain; format=flowed Received-SPF: pass client-ip=2607:f8b0:4864:20::834; envelope-from=gusbrs.2016@gmail.com; helo=mail-qt1-x834.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=WnEb3JjZ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: xXUxoGDW+aCC Hi All, when using `org-hide-emphasis-markers', making links visible with `org-toggle-link-display' also unhides the emphasis markers. I believe this to be unexpected behavior (it certainly is to me), but I might be wrong here, given that the emphasis markers are explicitly set to a `org-link' invisible property (which see). An ECM to reproduce the issue is: - Start `emacs -Q' - Do an initial setup: #+begin_src emacs-lisp (add-to-list 'load-path "~/.emacs.d/elpa/org-plus-contrib-20201123") (setq org-hide-emphasis-markers t) #+end_src - Open an Org buffer with contents: #+begin_src org [[https://orgmode.org/][Org mode for Emacs]] ,*bold* #+end_src given the settings, both the link and emphasis markers should be invisible. - Call `M-x org-toggle-link-display', see that both the link and the emphasis markers are made visible. Toggle it again, and both are invisible. As far as I dug, the reason for this behavior lies in `org-do-emphasis-faces' which indeed uses the `org-link' invisible property to hide the links (at the very end of the function): #+begin_src emacs-lisp (when (and org-hide-emphasis-markers (not (org-at-comment-p))) (add-text-properties (match-end 4) (match-beginning 5) '(invisible org-link)) (add-text-properties (match-beginning 3) (match-end 3) '(invisible org-link))) #+end_src So that `org-toggle-link-display' cannot really distinguish an emphasis marker from an actual link when it removes `org-link' from the invisibility-spec. I don't know why this is done this way in `org-do-emphasis-faces', so I might be missing something, but it does lead to this peculiar behavior of `org-toggle-link-display'. Best regards, Gustavo. Emacs : GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0) of 2020-08-11 Package: Org mode version 9.4 (9.4-44-g5272d9-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20201123/) current state: ============== (setq org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer) org-link-shell-confirm-function 'yes-or-no-p org-metadown-hook '(org-babel-pop-to-session-maybe) org-clock-out-hook '(org-clock-remove-empty-clock-drawer) org-mode-hook '(#[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook org-show-all append local] 5] #[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook org-babel-show-result-all append local] 5] org-babel-result-hide-spec org-babel-hide-all-hashes org-eldoc-load) org-archive-hook '(org-attach-archive-delete-maybe) org-confirm-elisp-link-function 'yes-or-no-p org-agenda-before-write-hook '(org-agenda-add-entry-text) org-metaup-hook '(org-babel-load-in-session-maybe) org-bibtex-headline-format-function #[257 "\300\236A\207" [:title] 3 "\n\n(fn ENTRY)"] org-babel-pre-tangle-hook '(save-buffer) org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand) org-hide-emphasis-markers t org-agenda-loop-over-headlines-in-active-region nil org-src-lang-modes '(("redis" . redis) ("php" . php) ("arduino" . arduino) ("C" . c) ("C++" . c++) ("asymptote" . asy) ("bash" . sh) ("beamer" . latex) ("calc" . fundamental) ("cpp" . c++) ("ditaa" . artist) ("dot" . fundamental) ("elisp" . emacs-lisp) ("ocaml" . tuareg) ("screen" . shell-script) ("shell" . sh) ("sqlite" . sql)) org-occur-hook '(org-first-headline-recenter) org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines org-optimize-window-after-visibility-change) org-speed-command-hook '(org-speed-command-activate org-babel-speed-command-activate) org-export-before-parsing-hook '(org-attach-expand-links) org-confirm-shell-link-function 'yes-or-no-p org-link-parameters '(("attachment" :follow org-attach-follow :complete org-attach-complete-link) ("id" :follow org-id-open) ("eww" :follow org-eww-open :store org-eww-store-link) ("rmail" :follow org-rmail-open :store org-rmail-store-link) ("mhe" :follow org-mhe-open :store org-mhe-store-link) ("irc" :follow org-irc-visit :store org-irc-store-link :export org-irc-export) ("info" :follow org-info-open :export org-info-export :store org-info-store-link) ("gnus" :follow org-gnus-open :store org-gnus-store-link) ("docview" :follow org-docview-open :export org-docview-export :store org-docview-store-link) ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link) ("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete org-bbdb-complete-link :store org-bbdb-store-link) ("w3m" :store org-w3m-store-link) ("file+sys") ("file+emacs") ("shell" :follow org-link--open-shell) ("news" :follow #[514 "\301\300\302Q\"\207" ["news" browse-url ":"] 6 "\n\n(fn URL ARG)"]) ("mailto" :follow #[514 "\301\300\302Q\"\207" ["mailto" browse-url ":"] 6 "\n\n(fn URL ARG)"]) ("https" :follow #[514 "\301\300\302Q\"\207" ["https" browse-url ":"] 6 "\n\n(fn URL ARG)"]) ("http" :follow #[514 "\301\300\302Q\"\207" ["http" browse-url ":"] 6 "\n\n(fn URL ARG)"]) ("ftp" :follow #[514 "\301\300\302Q\"\207" ["ftp" browse-url ":"] 6 "\n\n(fn URL ARG)"]) ("help" :follow org-link--open-help) ("file" :complete org-link-complete-file) ("elisp" :follow org-link--open-elisp) ("doi" :follow org-link--open-doi)) org-link-elisp-confirm-function 'yes-or-no-p )