Re: Fix org.el compilation warnings

[Kyle Meyer <kyle@kyleam.com>]

Kaushal Modi <kaushal.modi@gmail.com> writes:

>> Ah, right ... 'make compile' uses a single Emacs instance, while 'make
>> single' uses a separate Emacs instance for each file.
>
> I wasn't even doing that. I was doing M-x byte-compile-file and selecting
> org.el.

Sure, I was just noting why I didn't see the
org-agenda-include-inactive-timestamps warning when I ran 'make
compile'.  .

> That gives me (without applying your patch):
>
> Compiling file
> /home/kmodi/stow/pub_dotfiles/emacs/dot-emacs.d/elisp/org-mode/lisp/org.el
> at Fri May 26 14:04:52 2017
>
> In org-goto-map:
> org.el:7412:9:Warning: function org-goto-map used to take 0+ arguments, now
>     takes 0
>
> In org-todo:
> org.el:12398:12:Warning: function org-todo used to take 0+ arguments, now
>     takes 0-1
>
> In org-store-log-note:
> org.el:13635:8:Warning: function org-store-log-note used to take 0+
> arguments,
>     now takes 0
>
> In org-at-timestamp-p:
> org.el:17909:40:Warning: reference to free variable
>     ‘org-agenda-include-inactive-timestamps’
>
> In org-self-insert-command:
> org.el:19910:32:Warning: function org-self-insert-command used to take 0+
>     arguments, now takes 1
>
> So.. should we consider the warnings output by simple byte-compile-file?

When I run byte-compile-file on org.el (no Org loaded, with master's Org
first on the load-path), I don't see any of the above warnings aside
from the one for org-agenda-include-inactive-timestamps, which is fixed
by the patch.  And because running byte-compile-file from an Emacs
instance is affected by what's already been loaded, I think it's better
to focus on the output of 'make single'.

-- 
Kyle