emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Vitalie Spinu <spinuvit@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Refile is not using IDO
Date: Tue, 02 Feb 2016 17:41:14 +0100	[thread overview]
Message-ID: <87oabzjc9h.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87fuxbe5v1.fsf@gmail.com> (Vitalie Spinu's message of "Tue, 02 Feb 2016 11:58:26 +0100")

Hello,

Vitalie Spinu <spinuvit@gmail.com> writes:

> I cannot get IDO working with refile anymore. The following change seem to be
> relevant:
>
> @@ -12008,12 +11980,11 @@ this is used for the GOTO interface."
>    (unless org-refile-target-table
>      (user-error "No refile targets"))
>    (let* ((cbuf (current-buffer))
> -	 (partial-completion-mode nil)
>  	 (cfn (buffer-file-name (buffer-base-buffer cbuf)))
>  	 (cfunc (if (and org-refile-use-outline-path
>  			 org-outline-path-complete-in-steps)
> -		    'org-olpath-completing-read
> -		  'org-icompleting-read))
> +		    #'org-olpath-completing-read
> +		  #'completing-read))
>  	 (extra (if org-refile-use-outline-path "/" ""))
>  	 (cbnex (concat (buffer-name) extra))
>  	 (filename (and cfn (expand-file-name cfn)))
>
>
>
>
> And presumably obsoleted ido completion. I don't see anything mentioned in
> org-completion-use-ido, tough.

The idea behind this patch is that IDO completion should be handled by
IDO, not Org. IOW, Org uses `completing-read' and IDO does its magic,
e.g., by setting `completing-read-function'.

> How do I activate ido with refile now?

I cannot tell, I don't use IDO. In the worst case, you can always
replace `completing-read-function' with `ido-completing-read'. I assume
there is some setting in IDO allowing to do it automatically.


Regards,

-- 
Nicolas Goaziou

  parent reply	other threads:[~2016-02-02 16:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02 10:58 Refile is not using IDO Vitalie Spinu
2016-02-02 11:04 ` Vitalie Spinu
2016-02-02 16:41 ` Nicolas Goaziou [this message]
2016-02-02 17:55   ` Vitalie Spinu
2016-02-02 21:36     ` Nicolas Goaziou
2016-02-17 20:05       ` Vitalie Spinu
2016-02-17 20:23 ` Samuel Wales

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oabzjc9h.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=spinuvit@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).