From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: How to add a test?
Date: Sun, 28 Feb 2016 16:10:33 +0100
Message-ID: <87povguaza.fsf@nicolasgoaziou.fr>
References: <mailman.121.1456506036.25421.emacs-orgmode@gnu.org>
	<87r3fxnkes.fsf@pobox.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33722)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aa2xS-0001W6-D9
	for emacs-orgmode@gnu.org; Sun, 28 Feb 2016 10:08:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aa2xR-0007Ws-HA
	for emacs-orgmode@gnu.org; Sun, 28 Feb 2016 10:08:30 -0500
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:50198)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aa2xR-0007Wo-Am
	for emacs-orgmode@gnu.org; Sun, 28 Feb 2016 10:08:29 -0500
In-Reply-To: <87r3fxnkes.fsf@pobox.com> (George M. Jones's message of "Sun, 28
	Feb 2016 06:28:43 -0500")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: George M Jones <eludom@gmail.com>
Cc: emacs-orgmode@gnu.org

Hello,

George M Jones <eludom@gmail.com> writes:

> What's the process for adding a test (specifically to babel)?
>
> The only part that looks non-obvious is how to generate the test ID,
> e.g. in ob-shell-test.org:
>
>   * Associative array tests (simple map)
>     :PROPERTIES:
>     :ID:       bec1a5b0-4619-4450-a8c0-2a746b44bf8d
>     :END:
>
> From there it looks like you just add to the correct file in
> org-mode/testing/examples/*.org and the corresponding
> /org-mode/testing/lisp/test-*.el file.  Am I missing anything?
>
> I'll add to the README or docs unless it's already there.

I suggest to stay away from examples/ and `org-test-at-id' altogether.
I find these tests horrible to debug when something goes wrong.

I suggest to stay with `org-test-with-temp-text', or, if needed,
`org-test-with-temp-text-in-file' and make the test self-contained.
Also, I think it is better to have only one `should' or related, outside
of this macro, so the whole test is easier to evaluate partially. See,
e.g., "test-org-footnote.el".

Obviously YMMV and the more important thing is to have more tests. How
tests are written is a lesser matter. Feel free to ignore my
suggestions.

Thank you for your work.


Regards,

-- 
Nicolas Goaziou