From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id Y3wmCr2ocl+NfAAA0tVLHw (envelope-from ) for ; Tue, 29 Sep 2020 03:23:41 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id cGRnBb2ocl9feQAAbx9fmQ (envelope-from ) for ; Tue, 29 Sep 2020 03:23:41 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 383449402AD for ; Tue, 29 Sep 2020 03:23:40 +0000 (UTC) Received: from localhost ([::1]:41182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kN6Er-0007UZ-Pi for larch@yhetil.org; Mon, 28 Sep 2020 23:23:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kN6EU-0007UN-1L for emacs-orgmode@gnu.org; Mon, 28 Sep 2020 23:23:14 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:50643) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kN6ER-0007GN-I0; Mon, 28 Sep 2020 23:23:13 -0400 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 8F56F778DA; Mon, 28 Sep 2020 23:23:06 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=2OGlrsqZuCZgvBYWnS1dXmYKsgo=; b=BQbasC tbPfP9FULEVblPHoyNVfnXUPm7DgkHElyt7FQiWArkSeA0ZIkv5B+ihkX3Ee21QX 9JLhSXCrRjNcqzJI/GThzM78Y7y74Mj0SKZ0aJuSGAI2hSmjNUT/hA1mGb17s5WS IO/DPd5e4sGFulVNYW0L//pLqPGjSJzIdu9eI= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 86EF2778D9; Mon, 28 Sep 2020 23:23:06 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=2YdaQs6DA0kgPLCxClgZiO0AHSl+c1h8jw942NDYP7g=; b=iKn3nVmpI5zth0ALubnnLLXw49vt0/aN/l94j1AkLvOucfU9R3IY8/mcWoNy2CaxsXWi3njFEQugKVUN7ypCq9sTKdPV63+iP8fkFPF7VM8wspp/pIcqsYUewfV/OJhr8TpSBpF3Ct2gVJBwJoiPumD66r3tmAwh/qvNxLonzIY= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id BCA25778D7; Mon, 28 Sep 2020 23:23:05 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Ihor Radchenko Subject: Re: Cycling through TODO workflow joins the next line onto the current one In-Reply-To: <87ft78608z.fsf@localhost> References: <87tuvparnu.fsf@gnu.org> <87h7ropqph.fsf@gmail.com> <87d02cppsm.fsf@gmail.com> <87ft78608z.fsf@localhost> Date: Mon, 28 Sep 2020 23:22:59 -0400 Message-ID: <87r1qlqnak.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 16EFDBAE-0203-11EB-BC9C-01D9BED8090B-24757444!pb-smtp1.pobox.com Received-SPF: pass client-ip=64.147.108.70; envelope-from=kyle@kyleam.com; helo=pb-smtp1.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/28 23:23:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastien , emacs18@gmail.com, Krishan Kharagjitsing , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=pobox.com header.s=sasl header.b=BQbasC t; dkim=fail (rsa verify failed) header.d=kyleam.com header.s=mesmtp header.b=iKn3nVmp; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: 1iK9NajOMOBY Ihor Radchenko writes: >> On my emacs 27, following demonstrates the problem. > > The patch is attached. It should fix the problem. Thanks for the patch. > Subject: [PATCH] Do not remove trailing newline when deleting planning info > line. > > * lisp/org.el (org-add-planning-info): Remove front newline instead of > trailing newline when deleting planning info is completetly removed > from a heading. Fixes "Cycling through TODO workflow joins the next > line onto the current one". > > The old behaviour affected folded headlines containing only planning > info in the body: > > Before deletion: > * DONE Headline > CLOSED: [2020-09-23 Wed 21:39] > * test > > After deletion: > * DONE Headline > * test > > The newline after the first headline is hidden making both the > headlines appear at the same visual line. > > New behaviour: > After deletion: > * DONE Headline > * test > > All the folded text is completely removed. Nicely explained, and appears to work well. Applied (5d4c0f59d) with a couple of minor tweaks to the commit message: 1: 8e776cca1 ! 1: 5d4c0f59d Do not remove trailing newline when deleting planning info line. @@ Metadata Author: Ihor Radchenko ## Commit message ## - Do not remove trailing newline when deleting planning info line. + Do not remove trailing newline when deleting planning info line * lisp/org.el (org-add-planning-info): Remove front newline instead of - trailing newline when deleting planning info is completetly removed - from a heading. Fixes "Cycling through TODO workflow joins the next - line onto the current one". + trailing newline when planning info is completetly removed from a + heading. The old behaviour affected folded headlines containing only planning info in the body: @@ Commit message All the folded text is completely removed. + Reported-by: Krishan Kharagjitsing + Ref: https://orgmode.org/list/CAKXDJO2xUgBoTx-XcL7WbXyvP2Oj8iVEmdmRNCVzdRTEwzNR+Q@mail.gmail.com + ## lisp/org.el ## @@ lisp/org.el: (defun org-add-planning-info (what &optional time &rest remove) ;; If there is nothing more to add and no more keyword is