From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Survey: changing a few default settings for Org 9.4 Date: Wed, 19 Feb 2020 14:39:05 +0100 Message-ID: <87r1yq3ddy.fsf@gnu.org> References: <87pnebf2ku.fsf@gnu.org> <84k14ikfee.fsf@gmail.com> <87zhde3iue.fsf@gnu.org> <84ftf6k90h.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:40824) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4PZE-00066e-Rw for emacs-orgmode@gnu.org; Wed, 19 Feb 2020 08:39:09 -0500 In-Reply-To: <84ftf6k90h.fsf@gmail.com> (Marco Wahl's message of "Wed, 19 Feb 2020 14:21:34 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Marco Wahl Cc: emacs-orgmode@gnu.org Hi Marco, Marco Wahl writes: >> Can you propose a patch against the maint branch for the fixes above? > > Sure. See the attachments. Thanks... > From 49b00d2cf7ca4b8484e0a9679b39b62873ee30b6 Mon Sep 17 00:00:00 2001 > From: Marco Wahl > Date: Wed, 19 Feb 2020 13:48:01 +0100 > Subject: [PATCH 1/2] org: Fix corner case for org-kill-line > > * lisp/org.el (org-kill-line): Kill _all_ tags when the cursor is on the tags part. There is a problem with this patch: when on a empty heading with tags, killing the tags will let the cursor back right after the last "*". Not a big deal in most headlines, but when on the first headline, this leads to an error. I think org-kill-line should not try to do too much, and kill only parts of the tags when the cursor is in the middle of tags is the right thing to do. As for the other patch, I think it's important to explain that the whole subtree will be killed, even if not visible -- that's the whole point of this variable after all. So I'm sorry but these patches can't make it. Thanks anyway! -- Bastien