From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [PATCH] Fix Org-Collector Error in Global Scope Date: Mon, 26 Mar 2012 17:26:44 +0200 Message-ID: <87r4wf5qob.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:46268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCBnX-0007Vq-NZ for emacs-orgmode@gnu.org; Mon, 26 Mar 2012 11:25:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCBnV-0003ay-A0 for emacs-orgmode@gnu.org; Mon, 26 Mar 2012 11:25:31 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:61829) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCBnV-0003aJ-0o for emacs-orgmode@gnu.org; Mon, 26 Mar 2012 11:25:29 -0400 Received: by wgbdr1 with SMTP id dr1so2979006wgb.30 for ; Mon, 26 Mar 2012 08:25:26 -0700 (PDT) In-Reply-To: (Mike McLean's message of "Sat, 24 Mar 2012 09:45:12 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Mike McLean Cc: emacs-orgmode@gnu.org Hi Mike, Mike McLean writes: > When calling Org-Collector with =:id global=, the call to > =(org-narrow-to-subtree)= generates an error when the first line of > the org file is not a header. Given that =:id global= is designed to > use the entire file, the call to =(org-narrow-to-subtree)= is not even > necessary. This patch skips it for global scope collector calls. I applied a variant using 'eq instead of 'equal. Next time, can you provide a full commit message and a ChangeLog entry? When patches are sent using 'git format-patch', applying them with 'git am' put the correct author of the patch. Otherwise I have to do it manually, which I sometimes forget. Thanks for the patch and your help, -- Bastien