From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Maus Subject: Re: Git Store Link Broken? Date: Sat, 20 Feb 2010 19:48:17 +0100 Message-ID: <87r5of4uby.wl%maus.david@gmail.com> References: <87hbpbki7r.wl%ded-law@ddoherty.net> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: multipart/mixed; boundary="===============0370028564==" Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NiuO7-0004xB-1L for emacs-orgmode@gnu.org; Sat, 20 Feb 2010 13:49:11 -0500 Received: from [140.186.70.92] (port=38883 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NiuNs-0004wr-90 for emacs-orgmode@gnu.org; Sat, 20 Feb 2010 13:49:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NiuNN-0004X6-Bv for emacs-orgmode@gnu.org; Sat, 20 Feb 2010 13:48:26 -0500 Received: from mail-bw0-f212.google.com ([209.85.218.212]:56006) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NiuNM-0004Wf-P6 for emacs-orgmode@gnu.org; Sat, 20 Feb 2010 13:48:25 -0500 Received: by bwz4 with SMTP id 4so848045bwz.8 for ; Sat, 20 Feb 2010 10:48:22 -0800 (PST) In-Reply-To: <87hbpbki7r.wl%ded-law@ddoherty.net> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "Daniel E. Doherty" Cc: reimar.finken@gmx.de, Org Mode --===============0370028564== Content-Type: multipart/signed; boundary="pgp-sign-Multipart_Sat_Feb_20_19:48:13_2010-1"; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit --pgp-sign-Multipart_Sat_Feb_20_19:48:13_2010-1 Content-Type: multipart/mixed; boundary="Multipart_Sat_Feb_20_19:48:13_2010-1" --Multipart_Sat_Feb_20_19:48:13_2010-1 Content-Type: text/plain; charset=US-ASCII Hi Daniel, Daniel E. Doherty wrote: >Hello all, >I noticed when I upgraded org from 6.21 (which comes with Emacs) to the >git version (6.34trans), org-store-link stopped working. When I try to >store a link from dired, I get a stringp nil error, with this debugger >output: It's a small glitch in `org-git-store-link': Orgmode calls all registered store-link functions to see if one declares itself of being responsible for the particular file or buffer. `org-git-store-link' tries to make an assumption on whether the file that is currently visited is inside a git repository w/o taking into consideration that there are buffers that are not associated with a file -- like a dired buffer. Attached patch fixes this. HTH -- David -- OpenPGP... 0x99ADB83B5A4478E6 Jabber.... dmjena@jabber.org Email..... maus.david@gmail.com --Multipart_Sat_Feb_20_19:48:13_2010-1 Content-Type: application/octet-stream; type=patch Content-Disposition: attachment; filename="0001-Avoid-trying-to-run-org-git-store-link-on-buffers-th.patch" Content-Transfer-Encoding: base64 RnJvbSA5ZmZmNWFkMzU5MzNhODJhODUxMzhkNThiZjJjMjVhMmE2NzlkZWM0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBNYXVzIDxtYXVzLmRhdmlkQGdtYWlsLmNvbT4KRGF0 ZTogU2F0LCAyMCBGZWIgMjAxMCAxOTozNzoyMCArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEF2b2lk IHRyeWluZyB0byBydW4gYG9yZy1naXQtc3RvcmUtbGluaycgb24gYnVmZmVycyB0aGF0IGRvIG5v dCBvcGVyYXRlIG9uIGEgZmlsZS4KCi0tLQogY29udHJpYi9saXNwL29yZy1naXQtbGluay5lbCB8 ICAgMTEgKysrKysrLS0tLS0KIDEgZmlsZXMgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA1IGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2NvbnRyaWIvbGlzcC9vcmctZ2l0LWxpbmsuZWwgYi9j b250cmliL2xpc3Avb3JnLWdpdC1saW5rLmVsCmluZGV4IDZmYzc3NDIuLjQ1OTZlNDEgMTAwNjQ0 Ci0tLSBhL2NvbnRyaWIvbGlzcC9vcmctZ2l0LWxpbmsuZWwKKysrIGIvY29udHJpYi9saXNwL29y Zy1naXQtbGluay5lbApAQCAtMTc1LDExICsxNzUsMTIgQEAKIAogKGRlZnVuIG9yZy1naXQtc3Rv cmUtbGluayAoKQogICAiU3RvcmUgZ2l0IGxpbmsgdG8gY3VycmVudCBmaWxlLiIKLSAgKGxldCAo KGZpbGUgKGFiYnJldmlhdGUtZmlsZS1uYW1lIChidWZmZXItZmlsZS1uYW1lKSkpKQotICAgICh3 aGVuIChvcmctZ2l0LWdpdHJlcG9zLXAgZmlsZSkKLSAgICAgIChvcmctc3RvcmUtbGluay1wcm9w cwotICAgICAgIDp0eXBlICJnaXQiCi0gICAgICAgOmxpbmsgKG9yZy1naXQtY3JlYXRlLWdpdC1s aW5rIGZpbGUpKSkpKQorICAod2hlbiAoYnVmZmVyLWZpbGUtbmFtZSkKKyAgICAobGV0ICgoZmls ZSAoYWJicmV2aWF0ZS1maWxlLW5hbWUgKGJ1ZmZlci1maWxlLW5hbWUpKSkpCisgICAgICAod2hl biAob3JnLWdpdC1naXRyZXBvcy1wIGZpbGUpCisJKG9yZy1zdG9yZS1saW5rLXByb3BzCisJIDp0 eXBlICJnaXQiCisJIDpsaW5rIChvcmctZ2l0LWNyZWF0ZS1naXQtbGluayBmaWxlKSkpKSkpCiAK IChhZGQtaG9vayAnb3JnLXN0b3JlLWxpbmstZnVuY3Rpb25zICdvcmctZ2l0LXN0b3JlLWxpbmsp CiAKLS0gCjEuNi42LjEKCg== --Multipart_Sat_Feb_20_19:48:13_2010-1-- --pgp-sign-Multipart_Sat_Feb_20_19:48:13_2010-1 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iF4EABEIAAYFAkuALnEACgkQma24O1pEeOYqtQD/fwhiGPpa5bfFI/znBQmFSx2R jCCu5ALi0S1Aq0d9egUBANEOhB+G1JvYR+Q6Pl1drgnHrlADYJon4TYpz/9Uxj6Y =XOE2 -----END PGP SIGNATURE----- --pgp-sign-Multipart_Sat_Feb_20_19:48:13_2010-1-- --===============0370028564== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --===============0370028564==--