From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id tbtYMvRvcV/LaAAA0tVLHw (envelope-from ) for ; Mon, 28 Sep 2020 05:09:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id mHzbLfRvcV+6GgAA1q6Kng (envelope-from ) for ; Mon, 28 Sep 2020 05:09:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 988229403EE for ; Mon, 28 Sep 2020 05:09:07 +0000 (UTC) Received: from localhost ([::1]:60116 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMlPN-0007y8-20 for larch@yhetil.org; Mon, 28 Sep 2020 01:09:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMlP0-0007xn-3v for emacs-orgmode@gnu.org; Mon, 28 Sep 2020 01:08:42 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:62903) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMlOx-0006sQ-3F; Mon, 28 Sep 2020 01:08:41 -0400 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 4D5D96DB36; Mon, 28 Sep 2020 01:08:37 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=J1mlglSZw2Ww+cUWPyNDQPFOO68=; b=mBaU5N saNUsk0xb1B7zN6UTxrUvWmjq5i3cR3o4eYErsk0dK0GCu1jBHiVkBAHMpzwpXTy 3QDWDDowyJrreDhbBSKk9ptycT0gcTsAVfvxDUGG9K4aIo5SXofJCfgrLuWCzbBU KqbVf/WmsSTsTSfXVdv9rQD9Fm4mEJa8qcZVI= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 440FE6DB34; Mon, 28 Sep 2020 01:08:37 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=96UXK5VLlZSRA3yxWXs4FK/C0s1Kcz/iautIfVzVBTM=; b=1KQcAOMwNrW0FOvOS7zY4ldcFx5keuDJh6CmMyAsaqFvvJP62EtE/FngsxSqOPZlc8Vs5G981DNjKV7/L6YCgB1YIyJnjpB9in7Krn6I3qQgLltdgKubjK3KUJAvNulteJHLbzJS/ERfV7/9LBFHbcYylR1w4H/JG1wUYLOtflY= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id B2BF46DB33; Mon, 28 Sep 2020 01:08:36 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Ihor Radchenko Subject: Re: [PATCH] Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)] In-Reply-To: <87lfh060pb.fsf@localhost> References: <50f165b2-bdaf-4861-aab5-122cfef7d67c@www.fastmail.com> <5f6aa2e2.1c69fb81.9bff7.9127@mx.google.com> <87k0wkheik.fsf@gnu.org> <87lfh060pb.fsf@localhost> Date: Mon, 28 Sep 2020 01:08:35 -0400 Message-ID: <87tuviqyi4.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: AA125E18-0148-11EB-A416-01D9BED8090B-24757444!pb-smtp1.pobox.com Received-SPF: pass client-ip=64.147.108.70; envelope-from=kyle@kyleam.com; helo=pb-smtp1.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/28 01:08:37 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: B Goodr , Dmitrii Korobeinikov , Bastien , emacs-orgmode@gnu.org, Nicholas Savage Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=pobox.com header.s=sasl header.b=mBaU5N s; dkim=fail (rsa verify failed) header.d=kyleam.com header.s=mesmtp header.b=1KQcAOMw; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: UVcbfi34aQuA Ihor Radchenko writes: > Subject: [PATCH] Do not remove trailing newline when deleting planning info > line. > > * lisp/org.el (org-add-planning-info): Remove front newline instead of > trailing newline when deleting planning info is completetly removed > from a heading. Fixes "Cycling through TODO workflow joins the next > line onto the current one". Did you intended to send a different patch? This looks to be the same patch you sent at . Also, can someone could provide an example case that was fixed by ee3c3b554 (org.el: Allow empty subtrees to be folded back, 2020-09-05)? The report that prompted that commit didn't include one: https://orgmode.org/list/CA+Yh0SRPgeMUYAD0ds3TZnwpPKq8_mpact-OeKK-rXoQNb-eEg@mail.gmail.com I tried with --8<---------------cut here---------------start------------->8--- * TODO a * TODO b --8<---------------cut here---------------end--------------->8--- If I understand the original message by Dmitrii (+cc), the request was that, since starting up folded shows the first heading as * TODO a... tab should be able to fold the heading back to that state after expansion. But, trying with the current master (16f505db2), tab still doesn't fold that heading on my end. Unless we have a concrete reason to keep ee3c3b554, reverting it might be the best fix for this thread's issue.