emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Fabrice Popineau <fabrice.popineau@supelec.fr>
Cc: Bastien <bzg@gnu.org>,
	fabrice.popineau@centralesupelec.fr,
	"emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: Release 9.0.5
Date: Mon, 13 Feb 2017 17:26:39 +0100	[thread overview]
Message-ID: <87tw7ykqf4.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAFgFV9Ojoz+_BVv_MWArCcxotp4gdrktt4Ed5En=OpCoViUQ1Q@mail.gmail.com> (Fabrice Popineau's message of "Sat, 11 Feb 2017 16:37:02 +0100")

Hello,

Fabrice Popineau <fabrice.popineau@supelec.fr> writes:

> This one is about the file system which behaves differently under Windows :
>
> F test-org-export/file-uri
>     Test ‘org-export-file-uri’ specifications.
>     (ert-test-failed
>      ((should
>        (equal "file:///local.org"
>      (org-export-file-uri "/local.org")))
>       :form
>       (equal "file:///local.org" "file://d:/local.org")
>       :value nil :explanation
>       (arrays-of-different-length 17 19 "file:///local.org" "file://d:/
> local.org" first-mismatch-at 7)))
>
> The absolute path has the drive name. So actually not a failure.

Ok. I rewrote the equality test. Hopefully, it should pass on your
system.

> F test-org-pcomplete/keyword
>     Test keyword and block completion.
>     (ert-test-failed
>      ((should
>        (equal "#+startup: "
>      (org-test-with-temp-text "#+start<point>"
> (pcomplete)
> (buffer-string))))
>       :form
>       (equal "#+startup: " "#+STARTUP: ")
>       :value nil :explanation
>       (array-elt 2
> (different-atoms
>  (115 "#x73" "?s")
>  (83 "#x53" "?S")))))
>
> This one is because pcomplete is used to get completion, and the completion
> depends on
> the pcomplete-ignore-case variable, which makes pcomplete ignore case for
> windows-nt and cygwin by default.

I also fixed it.

> The last one is strange:
>
> F test-org-element/link-parser
>     Test ‘link’ parser.
>     (ert-test-failed
>      ((should
>        (equal "id"
>      (org-test-with-temp-text "[[id:aaaa]]"
> (org-element-property :type ...))))
>       :form
>       (equal "id" "fuzzy")
>       :value nil :explanation
>       (arrays-of-different-length 2 5 "id" "fuzzy" first-mismatch-at 0)))

I removed this particular test. "id" links are non-standard (i.e., they
need you to require Org ID library). Such a test should go in
"test-org-id.el", which doesn't exist yet.

> This is complete non sense, because when I evaluate the test form, I
> actually get "id" and I have
> no idea where this "fuzzy" may come from.

A "fuzzy" link is a link with no default type, per
`org-link-parameters'. It probably means `org-id' wasn't loaded at the
time of the test.

> Do you also get a warning like this:
> Making org-entities-user local to  *temp*-443480 while let-bound!
> in the *Messages* buffer ?

I don't.

Could you confirm tests are passing now?

Thank you.

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2017-02-13 16:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-10 13:53 Release 9.0.5 Bastien
2017-02-10 19:50 ` Jorge Morais Neto
2017-02-10 20:05   ` Bastien Guerry
2017-02-26 12:03   ` location of clocking out notes (was: Re: Release 9.0.5) Gregor Zattler
2017-02-26 13:21     ` location of clocking out notes Nicolas Goaziou
2017-02-10 20:25 ` Release 9.0.5 Fabrice Popineau
2017-02-10 21:37   ` Fabrice Popineau
2017-02-10 22:44     ` Fabrice Popineau
2017-02-11  0:47       ` Nicolas Goaziou
2017-02-11 15:37         ` Fabrice Popineau
2017-02-13 16:26           ` Nicolas Goaziou [this message]
2017-02-11  9:29     ` Colin Baxter
2017-02-10 22:12 ` Russell Adams
2017-02-12 22:29 ` Merge 9.0.5 to emacs master? (Was: Release 9.0.5) Kaushal Modi
2017-02-12 23:41   ` Kyle Meyer
2017-02-13  9:05     ` Merge 9.0.5 to emacs master? Bastien Guerry
2017-02-13 16:32       ` Kyle Meyer
2017-02-13 16:58         ` Rasmus
2017-02-13 18:04           ` Kyle Meyer
2017-04-18 13:02             ` Kaushal Modi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tw7ykqf4.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=fabrice.popineau@centralesupelec.fr \
    --cc=fabrice.popineau@supelec.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).