From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: patch for ob-sql.el: improve MySQL header formatting, and add db spec header vars Date: Sun, 03 Feb 2013 15:53:07 -0700 Message-ID: <87txptf1ph.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:57564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U28S9-0000OQ-KH for emacs-orgmode@gnu.org; Sun, 03 Feb 2013 17:54:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U28S8-0000oh-D7 for emacs-orgmode@gnu.org; Sun, 03 Feb 2013 17:54:25 -0500 Received: from mail-pb0-f50.google.com ([209.85.160.50]:48376) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U28S8-0000oa-6o for emacs-orgmode@gnu.org; Sun, 03 Feb 2013 17:54:24 -0500 Received: by mail-pb0-f50.google.com with SMTP id ro8so2875172pbb.23 for ; Sun, 03 Feb 2013 14:54:23 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Gary Oberbrunner Cc: Orgmode Mailing List Gary Oberbrunner writes: > Here's a better version of this patch, which also adds support for > :colnames, which I needed. And it adds some doc about what header args are > used. > > * add a header-row delimiter to the tables returned from mysql > * adds new sql-specific header args for the database connection, and > implements them for mysql > * adds support for :colnames (mysql only) > * (minor) adds an edebug spec to org-babel-result-cond to allow edebugging > through it > Hi Gary, Thanks for sharing this patch. It looks like a solid improvement of Org's SQL support, and I'd like to apply it, however I need to ask for two things first. Most importantly, given the size of the patch you'll have to complete the Emacs copyright assignment process, see [1]. Less importantly, if you could re-generate the patch using git format-patch, it will be much easier to apply. Thanks! > > > > On Fri, Feb 1, 2013 at 10:18 AM, Gary Oberbrunner wrote: > >> Let me know if this would be better as a pull request. This patch does >> three things: >> >> * add a header-row delimiter to the tables returned from mysql >> * adds new sql-specific header args for the database connection, and >> implements them for mysql >> * (minor) adds an edebug spec to org-babel-result-cond to allow >> edebugging through it >> >> -- >> Gary >> Footnotes: [1] http://orgmode.org/worg/org-contribute.html -- Eric Schulte http://cs.unm.edu/~eschulte