From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] lisp/org.el: make org-open-at-point handle parens in encoded urls correctly Date: Fri, 11 Aug 2017 18:10:56 +0200 Message-ID: <87valu5blb.fsf@nicolasgoaziou.fr> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgCWc-0002ow-M0 for emacs-orgmode@gnu.org; Fri, 11 Aug 2017 12:11:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgCWY-0002Fu-Lt for emacs-orgmode@gnu.org; Fri, 11 Aug 2017 12:11:02 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:33710) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dgCWY-0002Fi-F1 for emacs-orgmode@gnu.org; Fri, 11 Aug 2017 12:10:58 -0400 In-Reply-To: (Marc Ihm's message of "Thu, 10 Aug 2017 22:25:05 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Marc Ihm Cc: emacs-orgmode@gnu.org Hello, Marc Ihm writes: > the attached patch changes org-open-at-point in org.el: > > Currently, when opening an url the function org-open-at-point uses the > variable path, which is the result of applying org-link-unescape on > the original url. Thus, all special chars like '() "' etc. which were > originally encoded like %20%28 etc. are reverted to their clear text > form. This worked for me in most cases, but gives me errors when my > url contains encoded chars like '()', i.e. %28%29. > > The submitted patch fixes this by simply using the original url with > all special chars still encoded. > > Please consider applying it, if fit. Thank you. The problem here is that Org could introduce additional percent-encoding upon creating a link. This additional layer needs to be removed before opening the link. I think there's a deeper issue to solve here. Your patch is likely to move the problem elsewhere. Regards, -- Nicolas Goaziou