From: stardiviner <numbchild@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Paul Sexton <eeeickythump@gmail.com>, org-mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Add feature to org-drill to auto pronounce word
Date: Sun, 27 Jan 2019 10:50:13 +0800 [thread overview]
Message-ID: <87womqhl0a.fsf@gmail.com> (raw)
In-Reply-To: <87k1iry7e6.fsf@nicolasgoaziou.fr>
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Hello,
>
> stardiviner <numbchild@gmail.com> writes:
>
>> A gentle ping..
>
> I'm not sure "org-drill.el" is still actively maintained. I'm Cc'ing
> Paul Sexton. In the long run, I think this package could be packaged
> through ELPA instead.
It is indeed not actively maintained. But still has some user are using
it. I found some recently used in Org Mode ML mentioned it.
I will ping the author Paul Sexton, I would like to particited in
maintain it. If he agree to publish it to MELPA, I could help.
>
>>> * etc/ORG-NEWS: mentioned this new feature.
>
> Changes to "contrib/" directory are usually not mentioned in this
> file.
Removed now.
>
>>> +(defun org-drill-pronounce-word ()
>>> + "Pronounce word after querying."
>>> + (if org-drill-auto-pronounce
>>> + (shell-command-to-string
>>> + (format "%s %s %s &"
>>> + org-drill-pronounce-command org-drill-pronounce-command-args
>
> What are `org-drill-pronounce-command' and
> `org-drill-pronounce-command-args'? I don't see them defined anywhere.
>
I missed that. Now added.
> Also, please prefer `when' to one-armed `if'.
Modified.
>
>>> + (shell-quote-argument
>>> + (substring-no-properties
>>> + (org-get-heading 'no-tags 'no-todo 'no-priority 'no-comment)))))))
>>> +
>>> +(add-hook 'org-drill-entry-after-hook #'org-drill-pronounce-word)
>
> Could it be more integrated? Using hook is usually for users. If you can
> modify the code, you probably can do better.
Modified now.
Those two hooks I think is necessary for user to add custom actions. So
keep them.
>
> Regards,
Regards :)
--
[ stardiviner ]
I try to make every word tell the meaning what I want to express.
Blog: https://stardiviner.github.io/
IRC(freenode): stardiviner, Matrix: stardiviner
GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
next prev parent reply other threads:[~2019-01-27 2:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 8:44 [PATCH] Add feature to org-drill to auto pronounce word stardiviner
2019-01-24 14:25 ` stardiviner
2019-01-26 11:40 ` Nicolas Goaziou
2019-01-27 2:50 ` stardiviner [this message]
2019-01-27 21:15 ` Nicolas Goaziou
2019-01-29 10:40 ` stardiviner
2019-01-30 21:59 ` Nicolas Goaziou
2019-02-01 2:37 ` stardiviner
2019-02-01 12:07 ` Stig Brautaset
2019-02-03 13:52 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87womqhl0a.fsf@gmail.com \
--to=numbchild@gmail.com \
--cc=eeeickythump@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).