From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aPlnCcYaLmEx3wAAgWs5BA (envelope-from ) for ; Tue, 31 Aug 2021 14:04:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 6GskBcYaLmH/WwAA1q6Kng (envelope-from ) for ; Tue, 31 Aug 2021 12:04:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7A5621E448 for ; Tue, 31 Aug 2021 14:04:21 +0200 (CEST) Received: from localhost ([::1]:40408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mL2V2-0004hA-KN for larch@yhetil.org; Tue, 31 Aug 2021 08:04:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56912) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mL2UI-0004ex-5O for emacs-orgmode@gnu.org; Tue, 31 Aug 2021 08:03:34 -0400 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]:38442) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mL2UG-0006qe-M3 for emacs-orgmode@gnu.org; Tue, 31 Aug 2021 08:03:33 -0400 Received: by mail-pj1-x102b.google.com with SMTP id g13-20020a17090a3c8d00b00196286963b9so1805049pjc.3 for ; Tue, 31 Aug 2021 05:03:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:references:user-agent:in-reply-to :message-id:mime-version; bh=qmh35fvVmEulmVGDM7ywC78DpCf7B09Y8UDbVKIx5sQ=; b=oAKjYgMYqEh2XSdmbOq20rLJN3i9FwXr6YTXhFPxpr817ew6m0Jfkxtj9ut8kI0pvg r2nu352wjyWhLMkjwZOMhqTvmaRyIaW2Xwbcwtmwx6crjX6iMyVKGDxBkxNXwhMJu/7v e5zixwL+2MAWDdhOlmEzzkLttq4rONVs5Ne+QwEHnplAQoB0wfUekCQu/NGAGc0LC5sT 9OGb2deR0fOiBTfbfrX+xfMOJJDmMz4afUC32BslsfK9nxdjaBYbUxIbv1//jkZ5D1Yu OkevaD7KN97hf6j30fHdEB2qHUFSbgfo89QeGmRA061Mhwnsl8LMRIp2Nr7TtMFm+PCA KSvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:references:user-agent :in-reply-to:message-id:mime-version; bh=qmh35fvVmEulmVGDM7ywC78DpCf7B09Y8UDbVKIx5sQ=; b=noIeXRvxBHrkV4KfhjGJgwpxq8jCAQGDazoPXBYDF56DCE/RvgFyFtrFXNWQa2j0xH IxO+Dae1SdovuouhrQDJ5wkHdUmCyoaN1eX0Sb49CZQfY+39RQUvKUVNK2fwwXh/ZE3q eQFpFE0F3QohbLDh4ME377Nqfe/9a7W+AaAfGB0Qt450QwCVwMmAEYFzyDJznZXCyT8d jerf3sITo+sysDtN1Igc0GiiH8tHeFBWxibuFugvnqzK1EQ6W6nBHvWgpnf/BDL9Folh BtwQVjweclVU6o9fm3qf3HKVeo0N4TPUjn7fPX6D5YEWtA+nQ1d9pKtbYA0+ZxXO5qb8 zPvw== X-Gm-Message-State: AOAM5305o11wKekt6b311ef6/62E5YA6/dJ9SXEsMHRl+g/i8ulYYkPs JH6RK5xnmjzabE2Zq0V9q7yAeYs5Qis9cQ== X-Google-Smtp-Source: ABdhPJxRFLGXyF+IUlOSs4uHafaZfUZSJCI+tW2ti1QduQoAKzZB4X7kUXfIDhDYe5Ef2/49YjUUcg== X-Received: by 2002:a17:90a:c798:: with SMTP id gn24mr4913897pjb.97.1630411411073; Tue, 31 Aug 2021 05:03:31 -0700 (PDT) Received: from localhost (61-245-128-160.3df580.per.nbn.aussiebb.net. [61.245.128.160]) by smtp.gmail.com with ESMTPSA id v5sm7661740pfv.91.2021.08.31.05.03.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 05:03:30 -0700 (PDT) From: Timothy To: Morgan Willcock Subject: Re: [PATCH] ox-ascii.el: Fix justify when `indent-tabs-mode' is non-nil Date: Tue, 31 Aug 2021 19:59:52 +0800 References: <20210817230735.13336-1-mwillcock@precedence.co.uk> User-agent: mu4e 1.6.5; emacs 28.0.50 In-reply-to: <20210817230735.13336-1-mwillcock@precedence.co.uk> Message-ID: <87zgsxom7k.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::102b; envelope-from=tecosaur@gmail.com; helo=mail-pj1-x102b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630411461; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=qmh35fvVmEulmVGDM7ywC78DpCf7B09Y8UDbVKIx5sQ=; b=cFlCLxDcdHKTjeYD72W22JwdRcRz9zY63A3aXLdHgeS1ddEuA7t69/0yyItA4VrGjy/IJN wpVjsxVOCzA6GYUfps2Af5QLQ5GFYEWVu2YYj4lwlJT5RLh28MVGmsuIO5wdk3wtnicM2H oKTX3LD6OZ2nH2sjR6bxTCxYCL3qWK6xli6yQKUEZzqcGtP4gEw62ig9CyD5TshIJbOtQU 4jRm8PxhlEd4TcMSzGfMUA4ODmSwSAN+28TUMky1jYFxf6HLRaNmxq1CMHZ2o3CtlyQ3Xs HlzO7u9E/wZ31GOt6WHN94isE66p1XNdALEYh18Wblz29pIIn7o71wG7sG85KA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630411461; a=rsa-sha256; cv=none; b=V1KKANo3KpjpvRIz11FjjUO1M0l20lZDdhfvJmHsLYUJEWFN0WPeTQRyV9JFTDgQtmdeTF aQhhKqO1/p3TDbA7Aebyh9upXvh6SttX66gcbKQi+hlhHc5/acM2hjudey8LzplxirvW5m QI3pY86Bgy6DHTo4Cml7yyybhTDc1FyASk8FHOHkpv26f/CvR+EPpuT0epWWHeXLRibF9V C9ydn8S2FFek/uf2DUpBaJ9kiRg5W6MGDCZ3qmMNy0e8CZHkLxWD7EnM4jLGskkXhzB+8C NuGpuwvk2VzzsatFMxhBYxiOshw8dPuKct7sh+Me/+GyfmKYzzrth8uYZPvEGg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=oAKjYgMY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -0.62 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=oAKjYgMY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 7A5621E448 X-Spam-Score: -0.62 X-Migadu-Scanner: scn0.migadu.com X-TUID: 9+DNLN4n+MTn --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Morgan, > I=E2=80=99ve attached a patch to fix an issue where tab characters are ge= nerated by > the ASCII exporter when `indent-tabs-mode=E2=80=99 has its default value = of t. Thanks for finding this bug, fixing it, and sending us it =F0=9F=99=82. I w= as able to reproduce your test case with =E2=80=9Cemacs -Q=E2=80=9D (thanks for that, = by the way). As you suspected, with the small number of changed lines, this would be fin= e to accept without FSF assignment. However, your =E2=80=9Cpatch=E2=80=9D seems to consist of a diff at the bot= tom of your email and a commit message at the top?? It would be preferable if you could provide a =E2=80=9Cproper=E2=80=9D patch, that way you can get attribution for your h= elp instead of just someone committing it on your behalf. All the best, Timothy --=-=-=--