From: Kyle Meyer <firstname.lastname@example.org> To: email@example.com Cc: firstname.lastname@example.org Subject: Re: problem with org-highest-priority Date: Wed, 18 Nov 2020 21:19:28 -0500 Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> email@example.com writes: > Kyle Meyer <firstname.lastname@example.org> writes: > >> The change in behavior you describe came with 4f98694bf (Allow numeric >> values for priorities, 2020-01-30). Based on quickly skimming that >> commit, I think the issue boils down to intentionally not supporting a >> mix of numbers and letters. I'm out of time tonight to look at it too >> closely, but I think support for your use case could be restored with >> something like the lightly tested patch below. > > Thanks, I tested your patch, and it helps a little bit. > > - m-x org-priority works, I can set any priority from 0 to Z > - org-priority-down and org-priority-down doesn't work as expected, as > they worked previously. I dont step through all the priority cookies, > instead I quickly wind up in prio 0, then I'm stuck there, for lack of > better description. Thanks for testing it out. I haven't really reloaded the issue into my head yet, but perhaps there's just a bit more to tweak then. > I'm not sure how to proceed. It seems I'm the only org-user affected by > this change? Hard to say, though I'd bet not (especially if we consider users that aren't on v9.4 yet). As for proceeding, with your feedback, I'll plan to take another look, but it won't be right away, so anyone is welcome to beat me to an updated patch. Even if your formerly working approach wasn't actually envisioned (*), I think it'd make sense to bring back support (along with tests) if it doesn't add much complication. (*) Again, I haven't refreshed on this issue, and I'm a very boring user of A, B, and C priorities. > Should I maintain a local patch to get the behaviour I > want? What is the recomended way to do that? I usually run > org-plus-contrib from elpa. I'm perhaps not the best person to answer this as a non-ELPA user, though I'd imagine your two main options are 1) defining org-priority in your local config to override the builtin version, either with a pure redefinition or with advice-add's :override. 2) cloning the Org repo and keeping a branch with the patch on top of the maint branch For maintaining a local variant over a longer period, the latter is the better way to go because you'll be alerted when the patched version conflicts. But let's see...
prev parent reply other threads:[~2020-11-19 2:20 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-05 21:58 joakim 2020-10-06 5:09 ` Kyle Meyer 2020-11-18 22:17 ` joakim 2020-11-19 2:19 ` Kyle Meyer [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://orgmode.org * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Org-mode mailing list This inbox may be cloned and mirrored by anyone: git clone --mirror https://orgmode.org/list/0 list/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 list list/ https://orgmode.org/list \ email@example.com public-inbox-index list Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.yhetil.org/yhetil.emacs.orgmode nntp://news.gmane.io/gmane.emacs.orgmode AGPL code for this site: git clone https://public-inbox.org/public-inbox.git